Fix a skipped test #279
Merged
Fix a skipped test #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-zhukov
commented
May 25, 2018
| }) | ||
| ]) | ||
| css.modules({ minimize: true }), | ||
| extractText('css/[name].[contenthash:hex:8].css') |
There was a problem hiding this comment.
Had to change it in order to fix the contenthash issue.
|
Tests fail, because of prettier if I see that correctly. Any idea? |
|
Btw, very good point. We should switch to using the |
|
All errors have been fixed. @andywer I forgot to run Prettier and ESLint before committing 😐 |
andywer
approved these changes
May 25, 2018
andywer
pushed a commit
that referenced
this pull request
Jun 19, 2018
marcofugaro
pushed a commit
to marcofugaro/webpack-blocks
that referenced
this pull request
Sep 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on it I found out Extract Text Plugin is deprecated for webpack 4 and they suggest to use mini-css-extract-plugin.