Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LBaaS recon tests for generic mock client #101

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

LittleFox94
Copy link
Collaborator

LBaaS reconciliation tests now use the generic mock client provided by go-anxcloud.

Wow, this diff is small!

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@LittleFox94 LittleFox94 marked this pull request as draft June 27, 2022 13:48
@codeclimate
Copy link

codeclimate bot commented Jun 27, 2022

Code Climate has analyzed commit 4ed1e15 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.0% (-0.2% change).

View more on Code Climate.

LBaaS reconciliation tests now use the generic mock client provided by
go-anxcloud. Wow, this diff is small!
@LittleFox94 LittleFox94 force-pushed the lbaas-test-mock-client branch from e6fa177 to 4ed1e15 Compare September 26, 2022 08:10
@LittleFox94 LittleFox94 marked this pull request as ready for review September 26, 2022 08:11
@LittleFox94
Copy link
Collaborator Author

@marioreggiori I rebased this PR, let's merge this and then rebase #105? :)

@LittleFox94 LittleFox94 merged commit 1b568ed into main Sep 26, 2022
@LittleFox94 LittleFox94 deleted the lbaas-test-mock-client branch September 26, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants