Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover LoadBalancer VIP via tag #142

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Discover LoadBalancer VIP via tag #142

merged 3 commits into from
Nov 29, 2022

Conversation

toothstone
Copy link
Contributor

This a rough draft to allow CCM to discover VIP addresses via their Engine tag.

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@toothstone
Copy link
Contributor Author

@LittleFox94 I was able to confirm that this works in combination with ANXKUBE-763 / https://code.anexia.com/se/k8sengine/-/merge_requests/518 without any further changes.

Will test backwards compatability once I get my hands on cluster with the canonical VIPs still being used.

@toothstone
Copy link
Contributor Author

Will test backwards compatability once I get my hands on cluster with the canonical VIPs still being used.

Patched CCM successfully falls back to index calculated VIPs if no tagged Addresses are found.

@codeclimate
Copy link

codeclimate bot commented Nov 25, 2022 •
edited
Loading

Code Climate has analyzed commit 2c16421 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 65.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.7% (0.7% change).

View more on Code Climate.

@toothstone toothstone force-pushed the ANXKUBE-762/discover-vips branch from a82473b to 4a409d9 Compare November 25, 2022 10:59
@toothstone toothstone changed the title WIP: VIP address discovery from tag ANXKUBE-762: VIP address auto discovery from tag Nov 25, 2022
@toothstone toothstone marked this pull request as ready for review November 25, 2022 11:00
LittleFox94
LittleFox94 requested changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@LittleFox94 LittleFox94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes please, didn't look at the tests in detail yet

@LittleFox94 LittleFox94 added the minor indicates that this change introduces a change that increments the minor version label Nov 29, 2022
LittleFox94
LittleFox94 requested changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@LittleFox94 LittleFox94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments, but will do the changes myself due to our tight timeline

toothstone and others added 3 commits November 29, 2022 12:33
@toothstone @LittleFox94
ANXKUBE-762 ✨: Discover LB addresses based on tag
04c598f 
This adds auto discovery for LB addresses, using the canonical tag
"kubernetes-lb-vip-<cluster name>".
If no address with such a tag can be found, we fall back to the previous
canonical IP address calculations.

Co-authored-by: Mario Schäfer <[email protected]>
Co-authored-by: Mara Sophie Grosch <[email protected]>
@toothstone @LittleFox94
ANXKUBE-762 🗑️✅ Add fallback if VIP can't be discovered
6647559 
Co-authored-by: Mara Sophie Grosch <[email protected]>
@toothstone @LittleFox94
ANXKUBE-762 📝: Update changelog with VIP auto discovery
2c16421
@LittleFox94 LittleFox94 force-pushed the ANXKUBE-762/discover-vips branch from e0a8e99 to 2c16421 Compare November 29, 2022 11:34
@LittleFox94 LittleFox94 changed the title ANXKUBE-762: VIP address auto discovery from tag Discover LoadBalancer VIP via tag Nov 29, 2022
@LittleFox94 LittleFox94 merged commit 4a10f2d into main Nov 29, 2022
@LittleFox94 LittleFox94 deleted the ANXKUBE-762/discover-vips branch November 29, 2022 11:40
@LittleFox94 LittleFox94 added patch minor indicates that this change introduces a change that increments the minor version and removed minor indicates that this change introduces a change that increments the minor version patch labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@LittleFox94 LittleFox94 LittleFox94 approved these changes

Assignees
No one assigned
Labels
minor indicates that this change introduces a change that increments the minor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toothstone @LittleFox94