Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose metrics for lbaas operation durations #167

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Expose metrics for lbaas operation durations #167

merged 4 commits into from
Mar 20, 2023

Conversation

eiabea
Copy link
Contributor

@eiabea eiabea commented Feb 27, 2023 •
edited
Loading

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@codeclimate
Copy link

codeclimate bot commented Feb 27, 2023 •
edited
Loading

Code Climate has analyzed commit 990f472 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 63.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.5% (0.3% change).

View more on Code Climate.

@eiabea eiabea force-pushed the anxkube-855/expose-metrics-for-lbaas-operation-durations branch 3 times, most recently from e8b64e9 to 6e1f984 Compare March 2, 2023 17:00
@eiabea eiabea changed the title Anxkube 855/expose metrics for lbaas operation durations Expose metrics for lbaas operation durations Mar 2, 2023
@eiabea eiabea marked this pull request as ready for review March 2, 2023 17:23
@eiabea eiabea self-assigned this Mar 2, 2023
@eiabea eiabea requested a review from marioreggiori March 2, 2023 17:23
@eiabea eiabea force-pushed the anxkube-855/expose-metrics-for-lbaas-operation-durations branch 3 times, most recently from bcd1232 to b2c2151 Compare March 6, 2023 10:26
marioreggiori
marioreggiori suggested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@marioreggiori marioreggiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good so far.
I'm not sure about the big testing diff included in this PR. Maybe extract it into a separate one?
@LittleFox94 could you please also take a look?

@eiabea eiabea force-pushed the anxkube-855/expose-metrics-for-lbaas-operation-durations branch from b2c2151 to ced103c Compare March 6, 2023 15:15
@eiabea eiabea changed the base branch from main to anxkube-855/expose-metrics-for-lbaas-operation-durations-updates March 6, 2023 16:00
LittleFox94
LittleFox94 reviewed Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@LittleFox94 LittleFox94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh noes, had a pending comment all those days

@eiabea eiabea force-pushed the anxkube-855/expose-metrics-for-lbaas-operation-durations-updates branch from 50c0002 to 53896c9 Compare March 10, 2023 19:05
@eiabea eiabea requested a review from LittleFox94 March 17, 2023 10:23
@LittleFox94 LittleFox94 mentioned this pull request Mar 20, 2023
Merged
1 task
LittleFox94
LittleFox94 reviewed Mar 20, 2023
View reviewed changes
@eiabea eiabea force-pushed the anxkube-855/expose-metrics-for-lbaas-operation-durations branch from 23edc85 to a255404 Compare March 20, 2023 16:38
@LittleFox94 LittleFox94 changed the base branch from anxkube-855/expose-metrics-for-lbaas-operation-durations-updates to main March 20, 2023 16:41
@eiabea eiabea force-pushed the anxkube-855/expose-metrics-for-lbaas-operation-durations branch from 88dea78 to 90b6599 Compare March 20, 2023 17:12
eiabea added 4 commits March 20, 2023 18:14
@eiabea
Add metrics to reconcile function
9e0696e 
Metrics
  - Histograms
    - cloud_provider_anexia_reconcile_total_duration_seconds
    - cloud_provider_anexia_reconcile_create_resources_duration_seconds
  - Counter
    - cloud_provider_anexia_reconcile_create_errors_total
    - cloud_provider_anexia_reconcile_delete_retries_total
    - cloud_provider_anexia_reconcile_delete_errors_total
    - cloud_provider_anexia_reconcile_created_total
    - cloud_provider_anexia_reconcile_deleted_total
    - cloud_provider_anexia_reconcile_retrieved_resources_total
  - Gauge
    - cloud_provider_anexia_reconcile_resources_pending

Update ginkgo
Update golangci-lint

Use ginkgo for provider test

Signed-off-by: Manuel Zangl <[email protected]>
@eiabea
Add constLabels to every reconcile metric
244eaf0
@eiabea
Minor refactoring
5f9c905
@eiabea
Use Vecs for every new metric
990f472 
Upadate changelog
Update packages
Remove metric specific tests
@eiabea eiabea force-pushed the anxkube-855/expose-metrics-for-lbaas-operation-durations branch from 90b6599 to 990f472 Compare March 20, 2023 17:15
@eiabea eiabea merged commit e10aa17 into main Mar 20, 2023
@LittleFox94 LittleFox94 added enhancement New feature or request patch dependencies Pull requests that update a dependency file labels Apr 15, 2023
@nachtjasmin nachtjasmin deleted the anxkube-855/expose-metrics-for-lbaas-operation-durations branch July 22, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioreggiori marioreggiori marioreggiori requested changes

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@LittleFox94 LittleFox94 LittleFox94 approved these changes

Assignees

@eiabea eiabea

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eiabea @LittleFox94 @marioreggiori