Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions in push and pull-request workflows #181

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Update actions in push and pull-request workflows #181

merged 3 commits into from
Apr 3, 2023

Conversation

eiabea
Copy link
Contributor

@eiabea eiabea commented Mar 27, 2023 •
edited
Loading

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@eiabea eiabea self-assigned this Mar 27, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023 •
edited
Loading

Code Climate has analyzed commit a227537 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.5% (0.0% change).

View more on Code Climate.

@eiabea eiabea force-pushed the anxkube-924/update-github-workflows branch from bc4e00b to 848b1d0 Compare March 27, 2023 17:51
@eiabea eiabea requested a review from marioreggiori March 27, 2023 17:54
@eiabea eiabea marked this pull request as ready for review March 27, 2023 18:15
marioreggiori
marioreggiori approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@marioreggiori marioreggiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

You could optionally update setup-go to v4 and drop cache: true (as it is now enabled by default)

LittleFox94
LittleFox94 reviewed Apr 3, 2023
View reviewed changes
.github/dependabot.yml
Comment on lines 8 to +10
- LittleFox94
- marioreggiori
- eiabea
Copy link
Collaborator

@LittleFox94 LittleFox94 Apr 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@LittleFox94 LittleFox94 force-pushed the anxkube-924/update-github-workflows branch from 52999bd to 01d8c17 Compare April 3, 2023 10:23
eiabea and others added 3 commits April 3, 2023 12:24
@eiabea @LittleFox94
Update actions in push and pull-request workflows
20af5e7 
Add marioreggiori and eiabea as dependabot assignees
Update release drafter
Update ginkgo in hack
Add hack to dependabot
Update changelog
@LittleFox94
CI: update setup-go to v4
710400b
@LittleFox94
Update alpine version to fix CVE-2023-0464
a227537
@LittleFox94 LittleFox94 force-pushed the anxkube-924/update-github-workflows branch from 01d8c17 to a227537 Compare April 3, 2023 10:24
@LittleFox94
Copy link
Collaborator

@marioreggiori can you take another look? I updated to setup-go@v4 and then also updated the base image to fix a CVE, requiring an updated changelog

if happy, we can get this merged and released today :)

@marioreggiori marioreggiori merged commit f66fd17 into main Apr 3, 2023
@marioreggiori marioreggiori deleted the anxkube-924/update-github-workflows branch April 3, 2023 11:49
@LittleFox94 LittleFox94 added enhancement New feature or request ci no-changelog patch dependencies Pull requests that update a dependency file labels Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFox94 LittleFox94 LittleFox94 left review comments

@marioreggiori marioreggiori marioreggiori approved these changes

Assignees

@eiabea eiabea

Labels
ci dependencies Pull requests that update a dependency file enhancement New feature or request no-changelog patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eiabea @LittleFox94 @marioreggiori