Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated set-output in docker-scan job #188

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

eiabea
Copy link
Contributor

@eiabea eiabea commented Apr 6, 2023

Update changelog

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@eiabea eiabea self-assigned this Apr 6, 2023
@eiabea eiabea requested a review from marioreggiori April 6, 2023 09:53
@eiabea eiabea mentioned this pull request Apr 6, 2023
1 task
@codeclimate
Copy link

codeclimate bot commented Apr 6, 2023

Code Climate has analyzed commit b63ea64 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@marioreggiori marioreggiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nitpick 😬

@marioreggiori
Copy link
Contributor

@eiabea
Copy link
Contributor Author

eiabea commented Apr 6, 2023

For future reference: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

i tried the recommended solution:

echo "{tag}={sha-${GITHUB_SHA::7}}" >>$GITHUB_OUTPUT

and

echo "{tag}=sha-${GITHUB_SHA::7}" >>$GITHUB_OUTPUT

but that resulted in no tag at all: anx-cr.io/anexia/anx-cloud-controller-manager:

am I missing something here?

@marioreggiori
Copy link
Contributor

If I read it correctly the curly brackets are only showing placeholders.

My comment linking the blog post was only for documentation. So that if someone stumbles upon this PR in the future knows why this change was made.

Sorry for the confusion. Your first (and latest) commit LGTM 👍

@eiabea eiabea force-pushed the remove-deprecated-set-output-in-job branch from 304d185 to b63ea64 Compare April 11, 2023 07:26
@eiabea eiabea merged commit b409bc0 into main Apr 11, 2023
@nachtjasmin nachtjasmin deleted the remove-deprecated-set-output-in-job branch July 22, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants