Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANXKUBE-1032: fix leaky reconciliation pending metric #255

Merged
2 commits merged into from
Dec 12, 2023
Merged

ANXKUBE-1032: fix leaky reconciliation pending metric #255

2 commits merged into from
Dec 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2023 •
edited by ghost
Loading

Checklist

  • added release notes to Unreleased section in CHANGELOG.md
  • release go-anxcloud and update go.mod

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@ghost ghost self-assigned this Dec 11, 2023
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 11, 2023 •
edited
Loading

Code Climate has analyzed commit 269ea53 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.3% (1.5% change).

View more on Code Climate.

@ghost ghost force-pushed the ANXKUBE-1032/fix-leaky-reconciliation-pending-metric branch from 00aa3fa to 9453023 Compare December 11, 2023 09:54
@ghost ghost requested a review from 89Q12 December 11, 2023 11:28
89Q12
89Q12 reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@89Q12 89Q12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the two dependencies that have high vulnerabilities in this PR or an extra one?
Otherwise looks good to me 👍

@ghost
Copy link
Author

ghost commented Dec 11, 2023

Dependencies will be updated in a separate PR.

@ghost ghost force-pushed the ANXKUBE-1032/fix-leaky-reconciliation-pending-metric branch from 9453023 to 2964644 Compare December 12, 2023 12:48
@ghost ghost marked this pull request as ready for review December 12, 2023 12:48
@ghost ghost force-pushed the ANXKUBE-1032/fix-leaky-reconciliation-pending-metric branch from 2964644 to e9f31d8 Compare December 12, 2023 12:50
@ghost ghost requested a review from 89Q12 December 12, 2023 12:51
@ghost ghost force-pushed the ANXKUBE-1032/fix-leaky-reconciliation-pending-metric branch from e9f31d8 to 269ea53 Compare December 12, 2023 12:55
@ghost ghost merged commit 350765f into main Dec 12, 2023
@ghost ghost deleted the ANXKUBE-1032/fix-leaky-reconciliation-pending-metric branch December 12, 2023 12:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@89Q12