Handle rate limits by the Engine for LoadBalancer reconciliation #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the API requests expected to be unsuccessful against the engine. Unfortunately, the only tests I've done were just manual against a given cluster, due to the complexity of the given methods. Closes: ANXKUBE-1281
nachtjasmin
force-pushed
the
joster/change-lwsvlqoswwvu
branch
from
cf7d615 to
7dcd654
Compare
koflanx
approved these changes
Feb 18, 2025
|
Code Climate has analyzed commit 775c909 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 33.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.4% (-0.3% change). View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } else { | ||
| // something was deleted successfully, allow retrying to delete other things in case it failed for conflicts | ||
| allowRetry = true | ||
| if api.IsRateLimitError(err) { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
There was a problem hiding this comment.
I tried fixing this with a refactoring by extracting the error handling when destroying resources. @nachtjasmin
There was a problem hiding this comment.
Did I mention that I hate codeclimate? 🙈
thanks!
┌────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬──────────────────────────────────────────────────────────┐ │ Library │ Vulnerability │ Severity │ Status │ Installed Version │ Fixed Version │ Title │ ├────────────┼────────────────┼──────────┼────────┼───────────────────┼───────────────┼──────────────────────────────────────────────────────────┤ │ libcrypto3 │ CVE-2024-12797 │ HIGH │ fixed │ 3.3.2-r4 │ 3.3.3-r0 │ openssl: RFC7250 handshakes with unauthenticated servers │ │ │ │ │ │ │ │ don't abort as expected │ │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2024-12797 │ ├────────────┤ │ │ │ │ │ │ │ libssl3 │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ └────────────┴────────────────┴──────────┴────────┴───────────────────┴───────────────┴──────────────────────────────────────────────────────────┘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the API requests expected to be unsuccessful against the engine. Unfortunately, the only tests I've done were just manual against a given cluster, due to the complexity of the given methods.
Closes: ANXKUBE-1281
Checklist
Unreleasedsection in CHANGELOG.mdReferences
Depends on anexia-it/go-anxcloud#438.
Community Note