Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): Add option to skip the first view transition #51825

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Sep 19, 2023

This commit adds an option to the view transition feature to skip the first transition. This option is not available in RouterModule.forRoot.

resolves #51815

@atscott atscott added feature Issue that requests a new feature action: review The PR is still awaiting reviews from at least one requested reviewer area: router target: minor This PR is targeted for the next minor release labels Sep 19, 2023
@ngbot ngbot bot modified the milestone: Backlog Sep 19, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Sep 19, 2023
@atscott atscott force-pushed the skipfirstviewtransition branch from b1f2fd2 to 6672c44 Compare September 19, 2023 19:34
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atscott this looks great, thanks Andrew! 👍

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

This commit adds an option to the view transition feature to skip the first transition.
This option is not available in RouterModule.forRoot.

resolves angular#51815
@atscott atscott force-pushed the skipfirstviewtransition branch from 6672c44 to 8d9549e Compare September 19, 2023 22:57
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 20, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Sep 22, 2023

This PR was merged into the repository by commit 86e9146.

@dylhunn dylhunn closed this in 86e9146 Sep 22, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…1825)

This commit adds an option to the view transition feature to skip the first transition.
This option is not available in RouterModule.forRoot.

resolves angular#51815

PR Close angular#51825
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router detected: feature PR contains a feature commit feature Issue that requests a new feature target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to skip the initial view transition to avoid flicker-like appearance of initial content render
4 participants