This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): improve implementation of aria-activedescendant #11743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
a11y
Splaktar
force-pushed
the
autocomplete-improveA11y
branch
4 times, most recently
from
a2152a9 to
8876826
Compare
Splaktar
added
pr: merge ready
Splaktar
added
pr: presubmit-failures
needs: rebase
|
There are some e2e failures in g3 due to certain DOM lookups no longer returning results. It may be due to the change to There are also other unit test failures that need to be investigated. I can probably mitigate these issues once they are more clearly defined and communicated. |
Splaktar
force-pushed
the
autocomplete-improveA11y
branch
from
8876826 to
6e1c20e
Compare
|
Rebased. |
|
I've redeployed these changes to https://angularjs-material.firebaseapp.com/demo/autocomplete. I had recently deployed some |
Splaktar
commented
Aug 1, 2019
Splaktar
force-pushed
the
autocomplete-improveA11y
branch
from
6e1c20e to
264182d
Compare
|
Received feedback on this based on JAWS testing that scrolling of the options list should wrap. Opened #11766 to track that issue separate from this PR. |
|
Received feedback on this based on JAWS testing that the default Escape key behavior did not align with expectations. Noted that we do have the I've updated all of the demos to use |
- allow screen readers to do more and us to do less - remove extra calls to announce the item that is visually focused - remove tests for these extra live announcements - give every option an id for use with `aria-activedescendant` - use the `selected` class for styling and finding the active option - implement recommendations from a11y guides - add the clear button to the tab order - change input type to `text` - always define a `name` attribute - when the popup isn't expanded - `aria-owns` and `aria-activedescendant` shouldn't be defined - when the autocomplete is disabled - `aria-autocomplete` and `aria-role` shouldn't be defined - `aria-haspopup` should be false - add md-autocomplete-suggestion class for styling instead of using `li` - add `md-autoselect` to the dialog demo for help w/ manual testing - remove overly verbose `aria-describedby` from basic demo - mark `md-icons` in `md-item-templates` of autocomplete demos as hidden - update demos to use `md-escape-options="clear"` for better a11y Fixes #11742
Splaktar
force-pushed
the
autocomplete-improveA11y
branch
from
264182d to
1a51f24
Compare
|
It looks like the remaining presubmit issues can be handled within g3, then this will be able to get merged. |
andrewseguin
removed
the
needs: rebase
This was referenced Aug 18, 2019
norkunas
reviewed
Jan 27, 2020
jelbourn
pushed a commit
that referenced
this pull request
Jan 5, 2022
- allow screen readers to do more and us to do less - remove extra calls to announce the item that is visually focused - remove tests for these extra live announcements - give every option an id for use with `aria-activedescendant` - use the `selected` class for styling and finding the active option - implement recommendations from a11y guides - add the clear button to the tab order - change input type to `text` - always define a `name` attribute - when the popup isn't expanded - `aria-owns` and `aria-activedescendant` shouldn't be defined - when the autocomplete is disabled - `aria-autocomplete` and `aria-role` shouldn't be defined - `aria-haspopup` should be false - add md-autocomplete-suggestion class for styling instead of using `li` - add `md-autoselect` to the dialog demo for help w/ manual testing - remove overly verbose `aria-describedby` from basic demo - mark `md-icons` in `md-item-templates` of autocomplete demos as hidden - update demos to use `md-escape-options="clear"` for better a11y Fixes #11742 (cherry picked from commit 8c159aa)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ChromeVox announces the following when the user changes to the
AlaskaoptionWhen it should announce something like
Issue Number:
Fixes #11742
What is the new behavior?
aria-activedescendantselectedclass for styling and finding the active optiontextnameattributearia-ownsandaria-activedescendantshouldn't be definedaria-autocompleteandaria-roleshouldn't be definedaria-haspopupshould be falsemd-autocomplete-suggestionclass for styling instead of usinglimd-autoselectto the dialog demo for help w/ manual testingaria-describedbyfrom basic demomd-iconsinmd-item-templatesof autocomplete demos as hiddenDoes this PR introduce a breaking change?
Other information
Related resources
Live demo:
https://angularjs-material.firebaseapp.com/demo/autocomplete