Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend fixes: Import emails address list (CSV) #1976

Merged
merged 15 commits into from
Jan 17, 2025
Merged

frontend fixes: Import emails address list (CSV) #1976

merged 15 commits into from
Jan 17, 2025

Conversation

J43fura
Copy link
Collaborator

@J43fura J43fura commented Jan 15, 2025 •
edited
Loading

  • Increase upload size to 3MB
  • Dialog fullscreen, should be not fullscreen
  • Should be "Upload your file" instead of "Previous" in the 2nd screen
  • Email field should be displayed diffterently with accent, bold isn't enough
  • if header available show it before header mapping
  • Validate all rows instead of & show just first 5
  • Regexp must match the field with email only (besides spaces/triming)
  • Autodetect CSV separator firstly based on your computer language (see export's logic), the if no email column found, try another one based on the most common ones: ,;|\t
  • SameAs and Avatar URL should be available only for URL
  • Arrays destination field could be selectable multiple times, and could be splitted if it's empty or looks like an array
  • Boxes too close to the title line [most likely due to tailwind classes not being recognized] primevue default themes not reading certain tailwind classes #1978

image

J43fura added 14 commits January 13, 2025 11:35
@J43fura
increase maxFileSize to 3MB
de82d08
@J43fura
remove dialog fullscreen by default
46bdd03
@J43fura
if header available show it before header mapping
0beda01
@J43fura
highlight email field with contrast color
8a10f7c
@J43fura
button: "Upload your file" instead of "Previous"
74353b0
@J43fura
fix dialog fullscreen & default it in mobile
38aa6ec
@J43fura
Update MiningSettings.vue
55d5d2b
@J43fura
fix headers style
ff682a1
@J43fura
fix email regex: should be single email address
0daa014
@J43fura
Validate all rows instead of just first 5, and all columns
be4c5d5
@J43fura
Merge branch 'main' into 1016-import-emails-address-list-csv-or-xlx-b…
5a39b62 
…ackend
@J43fura
fix email validation
7cd050f
@J43fura
Disable select options accordingly
5861167 
- SameAs and Avatar URL available only for URL
- Email available only for Email
- empty columns are unavailable
- Rest available for the rest
@J43fura
Detect local CSV delimiter & try until successfull
07fde5a 
Autodetect CSV separator firstly based on your computer language (see export's logic), the if no email column found, try another one based on the most common ones: ,;|\t
@J43fura J43fura requested a review from maleksal January 15, 2025 09:51
@J43fura J43fura self-assigned this Jan 15, 2025
@J43fura J43fura linked an issue Jan 15, 2025 that may be closed by this pull request
Import emails address list (CSV or XLX) #1016
Open
@J43fura J43fura merged commit 36114a8 into main Jan 17, 2025
10 checks passed
@J43fura J43fura deleted the 1016-import-emails-address-list-csv-or-xlx-backend branch January 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleksal maleksal maleksal approved these changes

Assignees

@J43fura J43fura

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import emails address list (CSV or XLX)
2 participants
@J43fura @maleksal