-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action Fix #1906
Open
agureev
wants to merge
47
commits into
base
Choose a base branch
from
artem/bug-action-fix
base: base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Action Fix #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to origin/artem/ro-correct * apps/anoma_lib/lib/examples/enock.ex:
Storage now has `current_time` functionality to get the uncommitted height at the time of the call.
Replace a debug read backend with a proper read only transaction backend with following semantics: 1) RO Txs get launched directly through the executor 2) RO Txs only read and never write anything. 3) RO Txs get executed in the VM same any other transaction candidate. 4) RO Txs send the result of vm execution directly to the specified sender. 5) RO Txs read at most recent height 6) RO Txs other than the message specified in (4) do not send any other messages
If no transaction candidate ID is provided to the launch function of the Executor, generate a random ID using the same methodology as the Mempool.
All transactions should be launched with randomized IDs.
Implement an initial client storage.
Changes TRM types for getting rid of lists.
…nto artem/client-read-only
…artem/client-read-only
Currently the storage allows only for direct reads at a time. However, that will allow for impure behavior during scry evaluation. We mitigate this similarly to the Node NockmaVM, namely accompanying the keys to read with IDs which are stored in local tables.
…tem/client-prove-scry
…em/client-prove-scry
…em/client-prove-scry
As all 12 calls should query storage, we should assume we are querying the keyspaces.
…o artem/client-prove-scry
Previously, no scry function was provided for the prove evaluation. Now, we provide a scry function which checks whether a key is stored in client storage and if not, sends a read-only request to the node. Finally, if the resulting noun is a transaction, we store all app data marked for storage in the appropriate format.
Create a fixed-size interface for all integers for the TRM. That is, we see each integer in the system as an element of an enormously large field. Hence we provide an API to get the size of such a field.
The delta hash map for the TRM is a integer value of the jam of the underlying delta map, i.e. a map from a kind to its quntity.
The commitment accumulator for us is a set in TRM. Its root value is an integer value of its jam (after presenting the set in the noun format) cm acc
Create resource interface with the usual setup. Commitments/Nullifiers are now integers due to discussions re finite fields.
Create a compliance proving system interface. Keys are chosen to be the jam of the logic value of the appropriate jet to be written, which jets exactly to the verify jet function.
Create a resource logic proving system interface. Keys are determined by the resource to be verified.
Create a delta proving system interface. Keys are chosen to be the jam of the logic value of the appropriate jet to be written, which jets exactly to the verify jet function.
Create TRM Compliance Unit Interface. Practically simple field access and Proving System API use provided.
Create transparent action proving interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.