TRM V1 Removal #1913
Open
TRM V1 Removal #1913
+8,567
−3,872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e., those with a - in them somewhere.
Original merge of the branch artem/bug-root-check-table was incorrect as it did not respect the reading at keyspaces instead of atoms introduced in parallel branches merged beforehand. This fixes this, by reading the anchor at the anoma keyspace.
Make the layer and door computations explicit in the Jet module.
Prior, the jet registry carried the mug of the parent to compare against. However, mug computations for such large core can be expensive in Elixir due to murmur3 limitations. In order to speed up the process, we now store instead of mugs the actual parents and can compare against them during the jet checks.
Mug lookup is slower in Elixir due to Murmur3 implementation. Instead, our equality is faster and hence should be used in mug's stead. Hence now jet lookup goes through direct equality checking.
The reason why we'd want this is when running examples that have
capture log.
```
iex(anoma@YU-NO)1> Anoma.Node.Examples.ETransaction.resubmit_trivial_swap
"example_A2D042FF16911027DE1D9C09ABBFD2B6"
```
Is what we have after this patch but before this patch we have
```
iex(anoma@YU-NO)5> Anoma.Node.Examples.ETransaction.resubmit_trivial_swap
** (exit) exited in: GenServer.call(ExUnit.CaptureServer, {:log_capture_on, #PID<0.805.0>, #PID<0.1353.0>, []}, :infinity)
** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly because its application isn't started
(elixir 1.17.3) lib/gen_server.ex:1121: GenServer.call/3
(ex_unit 1.17.3) lib/ex_unit/capture_log.ex:110: ExUnit.CaptureLog.with_log/2
(ex_unit 1.17.3) lib/ex_unit/capture_log.ex:75: ExUnit.CaptureLog.capture_log/2
(anoma_node 0.30.0) lib/examples/e_transaction.ex:368: Anoma.Node.Examples.ETransaction.resubmit_trivial_swap/1
iex:5: (file)
```
There might be better places to put this however
Make sure intentpool has some time to process new events with nullifiers and commitments.
Changes TRM types for getting rid of lists.
…t_filters_mempool
…t_filters_logging
Use Encode and Decode Signed for heashing and de-hashing the deltas
Supplies witness may or may not be using integer representation of atoms
Provide usual Resource API: propositions testing commitment or nullifier
Provide a function to gather compliance unit roots.
Provides API to get roots and app data from the action.
Add transaction API, including getting all roots, all commitments, all nullifiers, or all app data from th underlying actions.
…trm-v31-integration
Remove all usage of previous transparent resource machine usage from the codebase.
agureev
force-pushed
the
artem/trm-v1-delete
branch
from
884f994 to
58c45e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TRM V1