Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a bug in cisco.nxos.nxos_vlans after return var #938

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

heathdbrown
Copy link

SUMMARY

regex pattern did not work when the 'name' was missing from a vlan adds fixture to show_running_config with this scenario for future tests

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cisco.nxos.nxos_vlans

ADDITIONAL INFORMATION
vlan 200
  vn-segment 200

after: { "vlan_id": 200, "mapped_vni": 200}

regex pattern did not work when the 'name' was missing from a vlan
adds fixture to show_running_config with this scenario for future tests
@AAYUSH2091
Copy link
Contributor

Hi @heathdbrown kindly add the change logs describing about the fix that was done.

@heathdbrown
Copy link
Author

Hi @heathdbrown kindly add the change logs describing about the fix that was done.

@AAYUSH2091 I added a changelog fragment.

@KB-perByte
Copy link
Collaborator

@heathdbrown there are a few test failures. can you please take a look? the CI needs to be green for us to review the PRs.

Please let us know if you need any help.
Regards

@AAYUSH2091 AAYUSH2091 assigned AAYUSH2091 and unassigned AAYUSH2091 Mar 12, 2025
@AAYUSH2091 AAYUSH2091 self-requested a review March 12, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants