[1.0.2] Add new unittest to validate current finalizer safety file i/o #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Sep 20, 2024
heifner
approved these changes
Sep 20, 2024
heifner
reviewed
Sep 20, 2024
In file included from ../plugins/producer_plugin/test/test_block_timing_util.cpp:3:
1153
../plugins/producer_plugin/include/eosio/producer_plugin/block_timing_util.hpp: In member function 'void block_timing_util::test_calculate_producer_wake_up_time::test_method()':
1154
../plugins/producer_plugin/include/eosio/producer_plugin/block_timing_util.hpp:132:18: warning: '<anonymous>.std::optional<fc::time_point>::<anonymous>.std::_Optional_base<fc::time_point, true, true>::_M_payload.std::_Optional_payload<fc::time_point, true, true, true>::<anonymous>.std::_Optional_payload_base<fc::time_point>::_M_payload.std::_Optional_payload_base<fc::time_point>::_Storage<fc::time_point, true>::_M_value.fc::time_point::elapsed.fc::microseconds::_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
1155
132 | return {};
1156
| ^
heifner
reviewed
Sep 20, 2024
heifner
approved these changes
Sep 20, 2024
linh2931
approved these changes
Sep 20, 2024
greg7mdp
changed the title
greg7mdp
changed the title
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #764
finalizer_tests/finalizer_safety_file_versioningvalidates loading older versions. Also validate current version: we should be able to load the reference file, save the fsi info, and end up with exactly the same bytes.