-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #2016 - Generate correct iGo code for lists in a grammar, such a… #3834
Conversation
…s `label+=arg+` Signed-off-by: Jim.Idle <[email protected]>
A test is missing. |
I agree but I see no way to add a test for this
Please add if you see a way.
…On Tue, Aug 23, 2022 at 17:36 Ivan Kochurkin ***@***.***> wrote:
A test is missing.
—
Reply to this email directly, view it on GitHub
<#3834 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMAN74CO53EOT7LSUA3V2SLS3ANCNFSM57J2GQVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
We use descriptor files for runtime tests, see antlr-project-testing.md. You can skip other runtimes using I added ListLabelInsideClosure.txt, but it fails on the execution step, see https://github.com/antlr/antlr4/runs/7982817143?check_suite_focus=true#step:23:1987
In fact, the bug is not fixed. |
I found this problem in
|
Thanks for the report. I will get this fixed in @dev
…On Sun, Oct 16, 2022 at 20:37 chen quan ***@***.***> wrote:
I found this problem in github.com/antlr/antlr4/runtime/Go/antlr v1.4.10.
grammar:
https://github.com/antlr/grammars-v4/tree/master/sql/mysql/Positive-Technologies
[image: image]
<https://user-images.githubusercontent.com/20548053/196035594-20e31da3-67e0-422f-967b-ac96245d9a5c.png>
out:
panic: interface conversion: antlr.PredictionContext is *antlr.EmptyPredictionContext, not *antlr.ArrayPredictionContext [recovered]
panic: interface conversion: antlr.PredictionContext is *antlr.EmptyPredictionContext, not *antlr.ArrayPredictionContext [recovered]
panic: interface conversion: antlr.PredictionContext is *antlr.EmptyPredictionContext, not *antlr.ArrayPredictionContext
—
Reply to this email directly, view it on GitHub
<#3834 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMATD5372PKS5NCGO33WDPZHXANCNFSM57J2GQVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@parrt @KvanTTT - I cannot reproduce this with the latest runtime code. I have some recollection of fixing this as part of some other code fix, but I cannot be sure. Code should refer to the But I believe that I fixed this as a byproduct of changing the code that calls I think that we can close this. I have verified that it all works at both codegen and runtime |
fix: #2016 Generate the correct Go code for
label+=arg+
in a grammarSigned-off-by: Jim.Idle [email protected]