Prefix RethinkDB server exceptions with RethinkDB server:
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not 100% sure if I love this solution of stringly typed programming. However it's in a string error message already, so maybe this is OK. Feedback welcome :) I haven't looked into #77 in too much depth yet, but I don't think this should cause a future conflict, one option for #77 is to add the error type as a keyword in the ex-info map. |
danielcompton
force-pushed
the
exception-prefix
branch
from
06e2b90 to
1f1bd43
Compare
danielcompton
force-pushed
the
exception-prefix
branch
from
1f1bd43 to
694266a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sometimes difficult for people to distinguish between an exception
thrown in the client library, and an exception from the server which is
sent back and thrown by the client library. This change prefixes
serverside exceptions to make this distinction clearer.
Fixes #95, fixes #94