Update #'rethinkdb.query/filter to allow optargs

[yurrriq]

Per the docstring:

By default RethinkDB will ignore documents where a specified field is missing.
Passing {:default (r/error)} as an optional argument will cause any
non-existence error to raise an exception.

Currently, something like...

(r/filter sq predicate {:default true})

...throws an exception:

Wrong number of args (3) passed to: query/filter

[danielcompton]

@yurriq could you add tests to cover this new feature as well? (Reminds me to add tests to my open PRs)

[yurrriq]

For sure.

[yurrriq]

I added a basic test that fails on 80f7da0 and passes on yurrriq/clj-rethinkdb@7927c6c, but I'm not thrilled with it...

Any ideas for improvement are most welcome.

[danielcompton]

Hey sorry for the delay on this, I've been away. I'll try and get to it in the next few days.

[yurrriq]

Sounds good.

[danielcompton]

This all looks pretty good, there's a few more things this needs before it's ready, but I'm happy to help/do the work on these:

• Update the docstring to match http://rethinkdb.com/api/javascript/filter/, e.g.

  • If default is set to true, documents with missing fields will be returned rather than skipped.
  • If default is set to r.error(), an RqlRuntimeError will be thrown when a document with a missing field is tested.
  • If default is set to false (the default), documents with missing fields will be skipped.

• Add test cases for all three defaults

• Modify existing test case to not use :bool true, and to filter on something different. To someone who wasn't familiar with filter, it looks like we're setting a default value (is :bool is not found, it equals true), rather than default behaviour (skipping/including record)

[yurrriq]

I merged in master, updated the docstring and modified/added tests. Let me know what you think.

[danielcompton]

Hey this looks great! Thanks so much.

[yurrriq]

Cheers!