Handle Task retries in Task SDK #44351
Assignees
Labels
Comments
kaxil
added
the
area:task-execution-interface-aip72
kaxil
changed the title
State.UP_FOR_RETRY) in Task SDK
kaxil
pushed a commit
that referenced
this issue
Dec 18, 2024
…lowSensorTimeout` (#44954) related: #44414 We already have support for handling terminal states from the task execution side as well as the task SDK client side. (almost) and failed state is part of the terminal state. This PR extends the task runner's run function to handle cases when we have to fail a task: `AirflowFailException, AirflowSensorTimeout`. It is functionally very similar to #44786 As part of failing a task, multiple other things also needs to be done like: - Callbacks: which will eventually be converted to teardown tasks - Retries: Handled in #44351 - unmapping TIs: #44351 - Handling task history: will be handled by #44952 - Handling downstream tasks and non teardown tasks: will be handled by #44951 ### Testing performed #### End to End with Postman 1. Run airflow with breeze and run any DAG  2. Login to metadata DB and get the "id" for your task instance from TI table  3. Send a request to `fail` your task  Or using curl: ``` curl --location --request PATCH 'http://localhost:29091/execution/task-instances/0193cec2-f46b-7348-9c27-9869d835dc7b/state' \ --header 'Content-Type: application/json' \ --data '{ "state": "failed", "end_date": "2024-10-31T12:00:00Z" }' ``` 4. Refresh back the Airflow UI to see that the task is in failed state. 
3 tasks
kaxil
pushed a commit
to astronomer/airflow
that referenced
this issue
Dec 27, 2024
kaxil
pushed a commit
to astronomer/airflow
that referenced
this issue
Dec 27, 2024
github-project-automation
bot
moved this from Next 2 Weeks
to Done
in AIP-72 - Task Execution Interface and SDK
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this issue
Jan 5, 2025
…lowSensorTimeout` (apache#44954) related: apache#44414 We already have support for handling terminal states from the task execution side as well as the task SDK client side. (almost) and failed state is part of the terminal state. This PR extends the task runner's run function to handle cases when we have to fail a task: `AirflowFailException, AirflowSensorTimeout`. It is functionally very similar to apache#44786 As part of failing a task, multiple other things also needs to be done like: - Callbacks: which will eventually be converted to teardown tasks - Retries: Handled in apache#44351 - unmapping TIs: apache#44351 - Handling task history: will be handled by apache#44952 - Handling downstream tasks and non teardown tasks: will be handled by apache#44951 ### Testing performed #### End to End with Postman 1. Run airflow with breeze and run any DAG  2. Login to metadata DB and get the "id" for your task instance from TI table  3. Send a request to `fail` your task  Or using curl: ``` curl --location --request PATCH 'http://localhost:29091/execution/task-instances/0193cec2-f46b-7348-9c27-9869d835dc7b/state' \ --header 'Content-Type: application/json' \ --data '{ "state": "failed", "end_date": "2024-10-31T12:00:00Z" }' ``` 4. Refresh back the Airflow UI to see that the task is in failed state. 
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this issue
Jan 30, 2025
…lowSensorTimeout` (apache#44954) related: apache#44414 We already have support for handling terminal states from the task execution side as well as the task SDK client side. (almost) and failed state is part of the terminal state. This PR extends the task runner's run function to handle cases when we have to fail a task: `AirflowFailException, AirflowSensorTimeout`. It is functionally very similar to apache#44786 As part of failing a task, multiple other things also needs to be done like: - Callbacks: which will eventually be converted to teardown tasks - Retries: Handled in apache#44351 - unmapping TIs: apache#44351 - Handling task history: will be handled by apache#44952 - Handling downstream tasks and non teardown tasks: will be handled by apache#44951 ### Testing performed #### End to End with Postman 1. Run airflow with breeze and run any DAG  2. Login to metadata DB and get the "id" for your task instance from TI table  3. Send a request to `fail` your task  Or using curl: ``` curl --location --request PATCH 'http://localhost:29091/execution/task-instances/0193cec2-f46b-7348-9c27-9869d835dc7b/state' \ --header 'Content-Type: application/json' \ --data '{ "state": "failed", "end_date": "2024-10-31T12:00:00Z" }' ``` 4. Refresh back the Airflow UI to see that the task is in failed state. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up of #44241 to handle Task retries i.e. checking max retries, setting correct state etc
The text was updated successfully, but these errors were encountered: