Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing values entries to Parameters in chart/README.md #11477

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 12, 2020

This PR Adds missing values entries to Parameters in chart/README.md


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil requested a review from dimberman October 12, 2020 19:00
@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 12, 2020
@kaxil kaxil force-pushed the add-missing-params-chart branch from 49fb99f to 0811f7f Compare October 12, 2020 19:01
@kaxil
Copy link
Member Author

kaxil commented Oct 12, 2020

@dimberman this was missing in #11426

@dimberman
Copy link
Contributor

@kaxil I figured we don't add it because a) there are no values for webserver and b) you can't add complex objects via CLI

@kaxil
Copy link
Member Author

kaxil commented Oct 12, 2020

@kaxil I figured we don't add it because a) there are no values for webserver and b) you can't add complex objects via CLI

In future we are going to automate generating this doc from values.schema.json. It is very useful to users to directly check what is configurable without having to look at values.yaml

@mik-laj
Copy link
Member

mik-laj commented Oct 12, 2020

In future we are going to automate generating this doc from values.schema.json. It is very useful to users to directly check what is configurable without having to look at values.yaml

Related: #11077

@kaxil kaxil requested review from turbaszek and potiuk October 12, 2020 23:02
@potiuk potiuk merged commit cb4cd91 into apache:master Oct 13, 2020
@kaxil kaxil deleted the add-missing-params-chart branch October 13, 2020 13:35
potiuk pushed a commit that referenced this pull request Nov 15, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 15, 2020
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 15, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
kaxil added a commit that referenced this pull request Nov 18, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants