-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parenthesis preventing keda ScaledObject creation #13183
fix parenthesis preventing keda ScaledObject creation #13183
Conversation
Disabling schema validation only for a few exceptional cases, I think is a good solution. We will have to be more careful in our reviews, but if it's not frequent, that's not a problem. If this is a problem then we will have to implement support for CRDs that have JSON Schema specifications, but this is an extra effort. We can do it later if needed. |
fd7c03f
to
ed3e36d
Compare
@mik-laj thanks for taking a look i realized i had forgotten to commit the tests I added! (just pushed) previously there were no tests related to keda (which is how this bug was able to stay hidden) so with this change at least we test the "should we create keda objects" condition. |
ed3e36d
to
6657c12
Compare
(cherry picked from commit a9d562e)
(cherry picked from commit a9d562e)
(cherry picked from commit a9d562e)
(cherry picked from commit a9d562e)
(cherry picked from commit a9d562e)
…#13183) Partial Commit Extracted From: https://github.com/apache/airflow
fix placement of parentheses in keda autoscaler template so that keda scaledobject is created when enabled
adds simple test to verify that keda object is created under right circumstances (though not all permutations covered)
to do so, had to make schema validation optional cus the existing validator could not find schema. maybe this is cus it's a custom resource def? @dimberman maybe you know?
closes: #13181