-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upgrading.rst with detailed code example of how to resolve post-upgrade warning #19993
Conversation
Give a detailed code example for how to drop the _airflow_moved__2_2__task_instance table to resolve post-upgrade warning
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Nice! I really like when we give "good" guidance to our users. |
Some whitespace problem :( |
I think there is an empty line problem |
Alternatively, you can drop the table by following the steps below: | ||
|
||
|
||
1. Exec into any of the Airflow pods - webserver or scheduler: ``kubectl exec -it <your-webserver-pod> python`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command example here is out of place since it is specific to Kubernetes, while the rest of the document does not make the assumption, and already assumes you have hooked into the machine/container/pod/whatever. I would only add the second bullet point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather give some more examples - kubernetes, docker, docker-compose and tell the users that this is an example and that they should find out what they should do in their environment.
I think our assumption is that this documentation is used by the users who had never done low-level DB operations with Airflow DB, and they likely have no idea how to get to their containers. Giving them at least a handy example they could follow and at least the starting point that will allow them to ask the right google question to dig deeper is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is just need to be in a note block that mention this is K8s specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note block makes sense
Noting the steps are specific to Kubernetes
Co-authored-by: Tzu-ping Chung <[email protected]>
Can we get update on that one :) @adaezebestow ? |
Hey @potiuk, I made an update specifying that the code suggestion is specific to Kubernetes. I tried unsuccessfully to reformat it into a note block. |
Docs are failing - I think you need ot look at similar .rst files :) something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably it's just missing a blank line.
I submitted a fix it should make the CI happy
Ci Indeed looks happy :) |
Awesome work, congrats on your first merged pull request! |
Give a detailed code example for how to drop the _airflow_moved__2_2__task_instance table to resolve post-upgrade warning
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.