fix(taskinstnace): set internal asset_type of all Asset subclass to "Asset" #47598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, asset_type is used to decide how we register asset event. (note that the asset_type here is object type instead of Asset.asset_type) As Asset might be subclass, all instances of Asset subclasses should have "Asset" as their asset_type
Lee-W
changed the title
Lee-W
force-pushed
the
correctly-handle-asset-type
branch
from
41d56c8 to
c298093
Compare
This was referenced Mar 11, 2025
Lee-W
changed the title
|
close it in favor of #47659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a temporary, unclean workaround and should be reworked later, but it can solve the current bug
Why
Currently,
asset_typedecides how we register asset events.(Note that the
asset_typehere is asset object type (e.g.,Asset,AssetAlias) instead ofAsset.asset_type)As
Assetmight be subclassed, all instances ofAssetsubclasses should have"Asset"as theirasset_type.What
If the object is an instance of
Asset, set theasset_type(the one we use to decide how we register asset events) to"Asset"^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.