Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional apt dependencies #9189

Merged
merged 4 commits into from
Jun 9, 2020

Conversation

22quinn
Copy link
Contributor

@22quinn 22quinn commented Jun 9, 2020

Support ADDITONAL_DEV_DEPS and ADDITONAL_RUNTIME_DEPS build arguments in both CI and production Dockerfile.

Related to: #8872


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. One more thing that could be useful is to add those additional deps as flags in Breeze. But it can be a separate request.

@22quinn
Copy link
Contributor Author

22quinn commented Jun 9, 2020

Thanks for reviewing. Not very familiar with Breeze scripts. Let me do some research and make it in another PR.

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADDITONAL_ should be ADDITIONAL_ @zikun ;)

@22quinn
Copy link
Contributor Author

22quinn commented Jun 9, 2020

ADDITONAL_ should be ADDITIONAL_ @zikun ;)

Good catch :) I just found another additonal in concepts.rst and fixed it together because it's not worth a separate PR. Hope this is fine?

@potiuk potiuk merged commit 82c8343 into apache:master Jun 9, 2020
@22quinn 22quinn deleted the docker-image-extra-dependencies branch June 11, 2020 12:41
@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 20, 2020
potiuk pushed a commit that referenced this pull request Jun 20, 2020
* Add ADDITONAL_DEV_DEPS and ADDITONAL_RUNTIME_DEPS

* Add examples for additional apt dev and runtime dependencies

* Update comment

* Fix typo

(cherry picked from commit 82c8343)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
* Add ADDITONAL_DEV_DEPS and ADDITONAL_RUNTIME_DEPS

* Add examples for additional apt dev and runtime dependencies

* Update comment

* Fix typo

(cherry picked from commit 82c8343)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
* Add ADDITONAL_DEV_DEPS and ADDITONAL_RUNTIME_DEPS

* Add examples for additional apt dev and runtime dependencies

* Update comment

* Fix typo

(cherry picked from commit 82c8343)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
* Add ADDITONAL_DEV_DEPS and ADDITONAL_RUNTIME_DEPS

* Add examples for additional apt dev and runtime dependencies

* Update comment

* Fix typo

(cherry picked from commit 82c8343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants