-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file-logger): support standard output for file logger plugins #8681
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
50dafda
feat: support std output in file logger plugin
e1ijah1 35804e4
chore: improve the code
e1ijah1 bd00d46
docs: update file-logger docs
e1ijah1 46ad5b5
chore: improve the code
e1ijah1 391a3b0
chore: improve the code
e1ijah1 19ac1bc
chore: improve the code
e1ijah1 8d755b5
fix: writing to stdout instead of a special file
e1ijah1 249abd1
chore: improve the code
e1ijah1 165b7f8
chore: run apisix without daemon mode
e1ijah1 ed53dc2
fix: use custom config
e1ijah1 15b7992
make ci happy
e1ijah1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
#!/usr/bin/env bash | ||
spacewander marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we remove the intermediate directory, so this file can be tested without modifying the ci script? |
||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
. ./t/cli/common.sh | ||
|
||
# setup upstream server | ||
echo ' | ||
nginx_config: | ||
main_configuration_snippet: | | ||
daemon off; | ||
http_configuration_snippet: | | ||
server { | ||
listen 15151; | ||
location / { | ||
return 201 "hello"; | ||
} | ||
} | ||
' > conf/config.yaml | ||
|
||
make init | ||
|
||
tmpout=$(mktemp) | ||
make run > "$tmpout" & | ||
|
||
sleep 0.2 | ||
|
||
curl -k -i http://127.0.0.1:9180/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' | ||
{ | ||
"uri": "/mock", | ||
"methods": [ | ||
"GET" | ||
], | ||
"plugins": { | ||
"file-logger": { | ||
"path": "stdout" | ||
} | ||
}, | ||
"upstream": { | ||
"nodes": [ | ||
{ | ||
"host": "127.0.0.1", | ||
"port": 15151, | ||
"weight": 1 | ||
} | ||
], | ||
"type": "roundrobin" | ||
} | ||
}' | ||
|
||
code=$(curl -v -k -i -m 20 -o /dev/null -s -w %{http_code} http://127.0.0.1:9080/mock) | ||
if [ ! $code -eq 201 ]; then | ||
echo "failed: check mock api failed" | ||
exit 1 | ||
fi | ||
|
||
make stop | ||
sleep 0.1 | ||
if [ `grep -c '"status":201' "$tmpout"` -ne '1' ]; then | ||
echo "failed: standard output of the file-logger plugin does not match expectations" | ||
cat "$tmpout" | ||
rm "$tmpout" | ||
exit 1 | ||
fi | ||
rm "$tmpout" | ||
|
||
echo "passed: the file-logger plugin produced the expected output" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is useless to print the access log only after the Nginx exited.