-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Python][CI] Add upper bound on pytest version #39827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65
@github-actions crossbow submit -g python -g wheel |
Revision: c91af6a Submitted crossbow builds: ursacomputing/crossbow @ actions-13f2836a4e |
I'll merge this so as to improve the state of our CI. |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 87dd4c4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65 ### What changes are included in this PR? Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
raulcd
pushed a commit
that referenced
this pull request
Feb 20, 2024
### Rationale for this change The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65 ### What changes are included in this PR? Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
### Rationale for this change The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65 ### What changes are included in this PR? Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
### Rationale for this change The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65 ### What changes are included in this PR? Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65
What changes are included in this PR?
Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.
Are these changes tested?
Yes, by construction.
Are there any user-facing changes?
No.