Support gRPC connection options for retry and timeout #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks more or less reasonable to me. The mypy failure doesn't look related to this PR? |
juergbi
force-pushed
the
juerg/grpc-settings
branch
2 times, most recently
from
798b97c to
f9f2c1e
Compare
The versions are taken from requirements.txt. This adds generated .pyi files for mypy.
juergbi
force-pushed
the
juerg/grpc-settings
branch
from
f9f2c1e to
c94baa2
Compare
juergbi
requested review from
gtristan,
BenjaminSchubert,
cs-shadow and
abderrahim
as code owners
It was related to the regeneration of protobuf code with updated tooling. Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.