Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ic uninitialized warning in release build #121

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Aug 4, 2023

Change logs

  • Fix ic uninitialized warning in release

Why are the changes needed?

  • Block the release build

Does this PR introduce any user-facing change?

  • nil

How was this patch tested?

  • no spec

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiiii, @jiaqizho welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!

@jiaqizho
Copy link
Contributor Author

jiaqizho commented Aug 4, 2023

@my-ship-it after sign CLA, the CLA bot become reviewer ? so weird about this action 😆

image

@tuhaihe
Copy link
Member

tuhaihe commented Aug 6, 2023

Hi, @jiaqizho: it should happen like this and not affect your PR review. Two reviewers with write access are still required for your PR approval.

@my-ship-it my-ship-it merged commit b655648 into apache:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants