add hashdata extension storage_am related hook, #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the QE will return its storage_am feature related meta data by control data tunnel,
we add hook when the QD processing the data returned from control data tunnel.
and also rewrite the check condiation for update scenario to make a wholerow attribute
for not only the appendonly table but all the tables except heap table including our
new hashdata involved table format.
closes: #ISSUE_Number
Change logs
for involving new hashdata table format extension , we need to a hook to process QE returned message,
also change a update scenario check condition to let new format table make a wholerow attribute.
If it has some breaking backward or forward compatibility, please clary.
no
Why are the changes needed?
currently there is no way to let the extension to control the message which QE returned on QD, we need a hook
to let the extension work its way.
Describe why the changes are necessary.
if there is such hook, extension cannot handle the message it returned from QE
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
no
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
it is well test with my extension code, including insert./update/delete/select scenarios
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel