Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: may cause UAF problem in get_size_from_segDBs #326

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix: may cause UAF problem in get_size_from_segDBs #326

merged 2 commits into from
Dec 11, 2023

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Dec 7, 2023 •
edited
Loading

fix #NO_ISSUE_NUMBER

Change logs

nope

Why are the changes needed?

In function get_size_from_segDBs, If the cdb result returned from segment is not as expected. Then we will clear up the cdb call the ereport. But in this cause the value in cdb result have been freed. We should keep a cdb result before cleanup it.

Does this PR introduce any user-facing change?

nope

How was this patch tested?

nope

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@avamingli
Copy link
Contributor

LGTM.

my-ship-it
my-ship-it approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiaqizho
Fix: may cause UAF problem in get_size_from_segDBs
0924717 
In function `get_size_from_segDBs`, If the cdb result returned from
segment is not as expected. Then we will clear up the cdb call the
ereport. But in this cause the value in cdb result have been freed.
We should keep a cdb result before cleanup it.
@jiaqizho jiaqizho force-pushed the fix-uaf-in-udf-get-size-from-segs branch from 37284ab to 0924717 Compare December 8, 2023 09:08
@avamingli
Copy link
Contributor

Pushed, thanks.

@avamingli avamingli merged commit 5003448 into apache:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avamingli avamingli avamingli approved these changes

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaqizho @avamingli @my-ship-it