Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: pgrx cannot find function after numeric change interface #410

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix: pgrx cannot find function after numeric change interface #410

merged 1 commit into from
Apr 23, 2024

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Apr 18, 2024 •
edited
Loading

Change logs

After CBDB public part of numeric defines, then numeric_is_nan/numeric_is_inf have been replace with macro NUMERIC_IS_NAN/NUMERIC_IS_INF.

But some of extension may not write by c/c++, then it can't direct call the macro NUMERIC_IS_NAN/NUMERIC_IS_INF. So current change add these function back.

Why are the changes needed?

nope

Does this PR introduce any user-facing change?

nope

How was this patch tested?

nope

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@jiaqizho jiaqizho requested a review from my-ship-it April 18, 2024 03:37
my-ship-it
my-ship-it approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiaqizho
Copy link
Contributor Author

@my-ship-it merge please

@my-ship-it my-ship-it merged commit 09ed012 into apache:main Apr 23, 2024
10 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
@jiaqizho
Fix: pgrx cannot find function after numeric change interface (apache…
55e4fa6 
…#410)

After CBDB public part of numeric defines, then numeric_is_nan/numeric_is_inf have been replace with
macro NUMERIC_IS_NAN/NUMERIC_IS_INF.

But some of extension may not write by c/c++, then it can't direct call the macro NUMERIC_IS_NAN/NUMERIC_IS_INF. 
So current change add these function back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaqizho @my-ship-it