Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change logs
External toast in CBDB have the fixed structure, the
vartag_external
used to tell which way to detoast it.If you want to add an external toast implementation in the extension without changing the kernel, then you need to add a new tag in
vartag_external
.The current change defines an extension generic tag which named
VARTAG_CUSTOM
, this kind of tag is not used in the kernel, which means that the datum returned from the extension should not be a toast with this kind of tag. This tag is only used within the extension.Why are the changes needed?
nope
Does this PR introduce any user-facing change?
nope
How was this patch tested?
nope
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳