Feature: Update orafce to 4.9 and enhance it #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreyes
changed the title
foreyes
changed the title
… (#13938) pipe function from unistd.h. This PR is back-ported from orafce/orafce@1f162a6 Co-authored-by: Bradford Boyle <[email protected]>
Update orafce to the latest version for further work: to support raw type in GPDB. (raw is one of the types in Oracle, which is the same as bytea.) - cherry-pick the previous modification for orafce to fit GPDB. - remove decode() supported by orafce, since they have already been implemented in GPDB. - enable set `protransform` in `pg_proc` (this behavior is disabled in 3.13), since the bug for setting GUC is fixed. - enable set `typstorage` in `pg_type` with `set allow_system_table_mods=true`. Changes with version 3.13: - changes the storage type from `plain` to `extended` for varchar2 and nvarchar2. `plain` specifies that data of the type will always be stored in-line and not compressed. `extended` specifies that the system will first try to compress a long data value, and will move the value out of the main table row if it's still too long. - move objects from pg_catalog/public to Oracle schema to avoid polluting these namespaces. Refer [commit](orafce/orafce@86a1b51) - varchar2 substr: - use oracle_substrb3 instead of bytea_substr - use oracle_substrb2 instead of bytea_substr_no_len - add dbms_sql schema, which provides interfaces to use dynamic SQL to parse any DML or DDL statement using PL/SQL. - add regexp function - add greatest function - add least function - add oracle.unistr - add oracle.translate_oracle_modifiers - add oracle.sys_guid - add oracle.to_char - add oracle.mod - add oracle.remainder - add dbms_utility.get_time - guarantee function parallel safe (useless for gp) User behavior changes: - user needs to set search_path to oracle to use functions in orafce: `set search_path = public, oracle;`. Upgrade from 3.13: - Users could still use 3.13 orafce in the latest GP7 or upgrade to 4.9 by `alter extension orafce update to '4.9'`. - After the upgrade from 3.13, the function/type in public/pg_catalog namespace will be moved to oracle namespace. Users who want to use these functions/types without code change could set search_path like `set search_path = public, oracle`.
foreyes
force-pushed
the
orafce
branch
2 times, most recently
from
18c238b to
4b88159
Compare
|
Should we keep "MERGE COMMIT" ? |
my-ship-it
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳