Fix segfilecount of AO/AOCO when bulk insertion: COPY #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
reviewed
Jul 22, 2024
Fix apache#529. For COPY FROM on AO/AOCO tables, we need to try switch physical seg files on the fly during bulk insertion. Else, only one insertDesc will be used and the GUC around segfilecount does't take effect. That's important for parallel plan. For AO specially, bulk insertion is optimized to reuse var block if possible, leads to additional check. Also fix memory leak for used_segment_files which is allocated at enter_dml_state() and shoule be preed when dml finished. Authored-by: Zhang Mingli [email protected]
|
external_fts pipeline config
which is not expected, remove that. |
my-ship-it
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #529.
For COPY FROM on AO/AOCO tables, we need to try switch physical seg files on the fly during bulk insertion. Else, only one insertDesc will be used and the GUC around segfilecount does't take effect.
That's important for parallel plan.
For AO specially, bulk insertion is optimized to reuse var block if possible, leads to additional check.
Also fix memory leak for used_segment_files which is allocated at enter_dml_state() and shoule be preed when dml finished.
Authored-by: Zhang Mingli [email protected]
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳