Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported java versions #160

Merged
merged 8 commits into from
May 10, 2022

Conversation

davecromberge
Copy link
Member

This removes support for Java9 and Java10. These versions are not LTS versions and in the case of Java9, no longer receive security patches.

@davecromberge davecromberge marked this pull request as draft May 4, 2022 14:46
@davecromberge
Copy link
Member Author

This is now ready for review.

@davecromberge davecromberge marked this pull request as ready for review May 4, 2022 20:36
@davecromberge davecromberge requested a review from leerho May 4, 2022 20:36
Copy link
Contributor

@leerho leerho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough.

@leerho leerho requested a review from AlexanderSaydakov May 4, 2022 21:36
@leerho
Copy link
Contributor

leerho commented May 4, 2022

Let's not merge just yet. I want to give Alex a chance to look at it.

@davecromberge
Copy link
Member Author

Thank you both for the review. I would like to include an additional runtime check on the runtime version in this PR, is it acceptable to throw an exception if the user is on an unsupported version? Strictly speaking, errors would only affect users allocating direct memory on Java 9 or 10, but I think it's safest just to disable them completely.

@leerho
Copy link
Contributor

leerho commented May 9, 2022

I talked to Alex and Will about your question. If the user, running 9 or 10 and not attempting to allocate off-heap memory, can do pretty much anything else, our recommendation is to just leave it be and not prematurely throw if you detect 9 or 10. As long as it is documented that we don't support 9 or 10 it should be OK. It would be nice it we could throw an intelligent error message if the user attempts to allocate off-heap memory.

@davecromberge
Copy link
Member Author

Thank you for this feedback - I think this makes sense. Design-wise, we could probably initialise the user runtime's capabilities as an enum and check these capabilities whenever the Memory API is invoked. Perhaps we can revisit this post-release.

In the meantime, I have reverted the premature exception since these versions might be implicitly supported if the user only allocates memory on heap. Once merged, I'll prepare these changes for release.

@davecromberge davecromberge merged commit 6f8e814 into master May 10, 2022
@davecromberge davecromberge deleted the remove-unsupported-java-versions branch May 10, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants