Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Reconcile exception #265

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[fix] Reconcile exception #265

merged 2 commits into from
Oct 16, 2024

Conversation

intelligentfu8
Copy link
Contributor

  1. delete redundancy code about get service.
  2. set resourceVersion ="" and set clusterIps = nil for different versions between kubernetes client and apiserver not match, which will result in a failed response.
  3. remove omit logic for using annotation to judge equal.

catpineapple
catpineapple approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@catpineapple catpineapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zy-kkk zy-kkk merged commit 81b79eb into apache:master Oct 16, 2024
@catpineapple catpineapple mentioned this pull request Oct 22, 2024
Closed
@intelligentfu8 intelligentfu8 deleted the reconcile_always branch November 8, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catpineapple catpineapple catpineapple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@intelligentfu8 @catpineapple @zy-kkk