-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](catalog) avoid calling checksum when replaying creating jdbc catalog and fix ranger issue #22369
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…ating jdbc catalog
87aa345
to
2b0d5ec
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
… jdbc catalog and fix ranger issue (#22369) 1. jdbc Before, in the constructor of Jdbc catalog, we may call checksum action of the jdbc driver. But the download link of the jdbc driver may not be available when replaying, causing replay error. This PR change the logic to avoid calling checksum when replaying creating jdbc catalog. 2. ranger After this PR, when creating catalog, it will try to init access controller to make sure the config is ok. 3. catalog priv check When creating/dropping/altering/ catalog, doris will only use internal access controller to check catalog level priv.
Proposed changes
Before, in the constructor of Jdbc catalog, we may call checksum action of the jdbc driver.
But the download link of the jdbc driver may not be available when replaying, causing replay error.
This PR change the logic to avoid calling checksum when replaying creating jdbc catalog.
ranger
After this PR, when creating catalog, it will try to init access controller to make sure the config is ok.
catalog priv check
When creating/dropping/altering/ catalog, doris will only use internal access controller to check catalog level priv.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...