-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) make TVF's distribution spec always be RANDOM #24020
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
454943c
to
93e7b61
Compare
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by anyone and no changes requested. |
run feut |
|
||
// when we set numbers to gather, coordinator could not process and set none scan range in thrift | ||
// so we add this test case to ensure this sql do not core dump | ||
sql """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this sql?
PR approved by at least one committer and no changes requested. |
Nereids make TVF number as Gather distribution if backend num = 1. But coordinator could not process gather fragment with scan node. In the long run, we need to get coordinators to support this scenario. But it is need a lot of refactor. So, we just forbid Gather distribution for ScanNode now.
Proposed changes
Issue Number: close #xxx
Nereids make TVF number as Gather distribution if backend num = 1.
But coordinator could not process gather fragment with scan node.
In the long run, we need to get coordinators to support this scenario.
But it is need a lot of refactor. So, we just forbid Gather
distribution for ScanNode now.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...