-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) fix multi window projection issue temporarily #24568
[fix](nereids) fix multi window projection issue temporarily #24568
Conversation
run buildall |
1 similar comment
run buildall |
93db471
to
9832142
Compare
run buildall |
9832142
to
17510f7
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes
Current multi-window plan generation has problem on the project sequence, for example:
and correspond physical plan is:
If the final plan is generated as following:
Before we eventually resolve the multi-window issue, we add a projection as following and force a mapping but this will not cover all potential problems.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...