-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](csv_reader)Fixed bug when parsing multi-character delimiters. #24572
Conversation
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
108bfb3
to
5e47b96
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
5e47b96
to
adfae23
Compare
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
TeamCity be ut coverage result: |
adfae23
to
942928c
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
…pache#24572) Fixed bug when parsing multi-character delimiters.
…24572) Fixed bug when parsing multi-character delimiters.
Proposed changes
Fixed bug when parsing multi-character delimiters.
example:
column_separator : "xx"
data.csv : data1xxxxdata2
Parse incorrectly:
data1[xx]xxdata2
data1x[xx]xdata2
data1xx[xx]data2
The string "xxxx" is parsed into three "xx" delimiters.
Parse correctly:
data1[xx]xxdata2
data1xx[xx]data2
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...