Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](csv_reader)Fixed bug when parsing multi-character delimiters. #24572

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Sep 18, 2023

Proposed changes

Fixed bug when parsing multi-character delimiters.

example:
column_separator : "xx"
data.csv : data1xxxxdata2

Parse incorrectly:
data1[xx]xxdata2
data1x[xx]xdata2
data1xx[xx]data2
The string "xxxx" is parsed into three "xx" delimiters.

Parse correctly:
data1[xx]xxdata2
data1xx[xx]data2

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@hubgeter hubgeter marked this pull request as ready for review September 18, 2023 13:29
@hubgeter
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.82% (7979/21669)
Line Coverage: 28.85% (64026/221934)
Region Coverage: 27.73% (33220/119783)
Branch Coverage: 24.36% (17031/69912)
Coverage Report: http://coverage.selectdb-in.cc/coverage/108bfb364d4b1798b8c9efdc9286c5feff563f12_108bfb364d4b1798b8c9efdc9286c5feff563f12/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.17 seconds
stream load tsv: 600 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162267551 Bytes

@hubgeter
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7979/21667)
Line Coverage: 28.85% (64028/221937)
Region Coverage: 27.73% (33219/119781)
Branch Coverage: 24.36% (17029/69912)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5e47b96e503514421952b08b218dd7bd19512f73_5e47b96e503514421952b08b218dd7bd19512f73/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.52 seconds
stream load tsv: 596 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162306529 Bytes

Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.75% (7979/21713)
Line Coverage: 28.82% (64034/222200)
Region Coverage: 27.71% (33237/119933)
Branch Coverage: 24.35% (17039/69988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5e47b96e503514421952b08b218dd7bd19512f73_5e47b96e503514421952b08b218dd7bd19512f73/report/index.html

@morningman
Copy link
Contributor

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2023
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.76% (7981/21713)
Line Coverage: 28.83% (64058/222200)
Region Coverage: 27.72% (33251/119933)
Branch Coverage: 24.35% (17044/69988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/adfae23a8df06fa7e67b0ccad308dd9382a2952f_adfae23a8df06fa7e67b0ccad308dd9382a2952f/report/index.html

@hubgeter
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.69% (7981/21755)
Line Coverage: 28.74% (64052/222902)
Region Coverage: 27.64% (33249/120284)
Branch Coverage: 24.28% (17039/70168)
Coverage Report: http://coverage.selectdb-in.cc/coverage/942928cdb67ebded758d8e11a47a673cdc2538dd_942928cdb67ebded758d8e11a47a673cdc2538dd/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.2 seconds
stream load tsv: 601 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162463195 Bytes

@morningman morningman merged commit c704497 into apache:master Sep 20, 2023
JingDas pushed a commit to JingDas/doris that referenced this pull request Sep 20, 2023
xiaokang pushed a commit that referenced this pull request Sep 20, 2023
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants