Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](timezone) fix timezone parse when there is no tzfile #24578

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

When there's no tzfile:
before:

mysql [test]>select convert_tz('2020-12-12 12:00:00', 'Asia/Shanghai', 'America/Los_angeles');
+--------------------------------------------------------------------------------------------------+
| convert_tz(cast('2020-12-12 12:00:00' as DATETIMEV2(0)), 'Asia/Shanghai', 'America/Los_angeles') |
+--------------------------------------------------------------------------------------------------+
| NULL                                                                                             |
+--------------------------------------------------------------------------------------------------+
1 row in set (0.03 sec)

after:

mysql [test]>select convert_tz('2020-12-12 12:00:00', 'Asia/Shanghai', 'America/Los_angeles');
+--------------------------------------------------------------------------------------------------+
| convert_tz(cast('2020-12-12 12:00:00' as DATETIMEV2(0)), 'Asia/Shanghai', 'America/Los_angeles') |
+--------------------------------------------------------------------------------------------------+
| 2020-12-11 20:00:00                                                                              |
+--------------------------------------------------------------------------------------------------+
1 row in set (0.03 sec)

It tested in docker.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

@jacktengg PTAL

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21667)
Line Coverage: 28.86% (64050/221936)
Region Coverage: 27.75% (33239/119779)
Branch Coverage: 24.37% (17038/69912)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7eded1590adefe241ca142c831f67146dfab8b8d_7eded1590adefe241ca142c831f67146dfab8b8d/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.79 seconds
stream load tsv: 614 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162138368 Bytes

Copy link
Contributor

@jacktengg jacktengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADD a UT or regression test

@zclllyybb
Copy link
Contributor Author

run buildall

HappenLee
HappenLee previously approved these changes Sep 19, 2023
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xinyiZzz
xinyiZzz previously approved these changes Sep 19, 2023
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.17 seconds
stream load tsv: 615 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162235655 Bytes

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 19, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.69 seconds
stream load tsv: 595 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162378987 Bytes

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.84% (7999/21715)
Line Coverage: 28.93% (64277/222204)
Region Coverage: 27.80% (33337/119933)
Branch Coverage: 24.41% (17081/69988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9c4f4cc912547f020698f750bbec4ed183bf1b56_9c4f4cc912547f020698f750bbec4ed183bf1b56/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.28 seconds
stream load tsv: 589 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.5 seconds inserted 10000000 Rows, about 350K ops/s
storage size: 17162372610 Bytes

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.76% (8008/21787)
Line Coverage: 28.81% (64309/223237)
Region Coverage: 27.69% (33361/120459)
Branch Coverage: 24.30% (17086/70306)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9c4f4cc912547f020698f750bbec4ed183bf1b56_9c4f4cc912547f020698f750bbec4ed183bf1b56/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.58 seconds
stream load tsv: 599 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162543019 Bytes

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants