Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](compile) failed on arm platform, with clang compiler and pch on, close #24633 #24636

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

gohalo
Copy link
Contributor

@gohalo gohalo commented Sep 19, 2023

Proposed changes

Issue Number: close #24633

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@gohalo gohalo changed the title [fix](compile) failed on arm platform, with clang compiler and pch on [fix](compile) failed on arm platform, with clang compiler and pch on, close #24633 Sep 19, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.19 seconds
stream load tsv: 610 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162298009 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.42% (8021/22024)
Line Coverage: 28.71% (64373/224244)
Region Coverage: 27.65% (33412/120819)
Branch Coverage: 24.29% (17092/70358)
Coverage Report: http://coverage.selectdb-in.cc/coverage/161ea9c3e7f3a5c4c389a144b8e333fae72af1ca_161ea9c3e7f3a5c4c389a144b8e333fae72af1ca/report/index.html

@xiaokang
Copy link
Contributor

@gohalo please fix clang format and then run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.41% (8019/22024)
Line Coverage: 28.70% (64351/224245)
Region Coverage: 27.65% (33405/120819)
Branch Coverage: 24.29% (17088/70358)
Coverage Report: http://coverage.selectdb-in.cc/coverage/161ea9c3e7f3a5c4c389a144b8e333fae72af1ca_161ea9c3e7f3a5c4c389a144b8e333fae72af1ca/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.89 seconds
stream load tsv: 613 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162342832 Bytes

@gohalo gohalo force-pushed the bugfix-compile-failed-arm branch from fec6519 to a50d520 Compare September 25, 2023 05:05
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.3 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17161983000 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.32% (8140/22413)
Line Coverage: 28.43% (65139/229104)
Region Coverage: 27.39% (33777/123299)
Branch Coverage: 24.05% (17237/71670)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a50d520dd321362ba465aa8208e4669c9a613961_a50d520dd321362ba465aa8208e4669c9a613961/report/index.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 27, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 19cff5d into apache:master Sep 27, 2023
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug](compile) On arm platform, there are some compile errors
5 participants