-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore](show partitions) show partitions print commit version #28274
[chore](show partitions) show partitions print commit version #28274
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
b8611aa
to
8e5d78c
Compare
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
8e5d78c
to
e3a09a8
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
e3a09a8
to
f6d1847
Compare
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f6d1847
to
d365bc0
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-DS: Total hot run time: 167591 ms
|
ClickBench: Total hot run time: 29.87 s
|
run p1 |
run cloud_p0 |
run cloud_p1 |
@@ -380,6 +380,9 @@ private List<Pair<List<Comparable>, TRow>> getPartitionInfosInrernal() throws An | |||
trow.addToColumnValue(new TCell().setStringVal(FeConstants.null_string)); | |||
} | |||
|
|||
partitionInfo.add(partition.getCommittedVersion()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the result of CloudPartition.getCommittedVersion()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloud partition no committed version, no real meaning, no changed
run buildall |
TPC-H: Total hot run time: 41528 ms
|
TPC-DS: Total hot run time: 170181 ms
|
ClickBench: Total hot run time: 29.86 s
|
run cloud_p1 |
run feut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
## Proposed changes Issue Number: close #xxx
…#28274) ## Proposed changes Issue Number: close #xxx
## Proposed changes Issue Number: close #xxx
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...