Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](function) Fix function for cast string as date/datetime #35637

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[Bug](function) Fix function for cast string as date/datetime #35637

merged 1 commit into from
Jun 5, 2024

Conversation

yongjinhou
Copy link
Contributor

@yongjinhou yongjinhou commented May 30, 2024 •
edited
Loading

Proposed changes

Issue Number: close #35635

Cast rules：Consistent with mysql.
String：Date
The first part is 1-digit x: 000x-month-day
The first part is 2-digit xy: 20xy-month-day / 19xy-month-day
The first part is 3-digit xyz: 20xy-0z-day / 19xy-0z-day
The first part is 4-digit xyzw: xyzw-month-day

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yongjinhou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42114 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ddedf023ff725d46a9e84d3ce4ba83b43a44c3c, data reload: false

------ Round 1 ----------------------------------
q1	17594	4303	4227	4227
q2	2009	194	196	194
q3	10458	1274	1199	1199
q4	10198	779	755	755
q5	7474	2804	2728	2728
q6	219	129	134	129
q7	971	607	622	607
q8	9216	2142	2137	2137
q9	9486	6719	6729	6719
q10	9201	3905	3948	3905
q11	455	240	243	240
q12	494	231	242	231
q13	17510	3216	3198	3198
q14	270	219	238	219
q15	522	474	489	474
q16	536	403	402	402
q17	1010	673	697	673
q18	8196	7798	7905	7798
q19	4579	1607	1612	1607
q20	663	318	325	318
q21	5165	4028	4091	4028
q22	390	328	326	326
Total cold run time: 116616 ms
Total hot run time: 42114 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4456	4444	4376	4376
q2	366	266	278	266
q3	3187	2917	2894	2894
q4	2007	1690	1667	1667
q5	5334	5520	5525	5520
q6	215	129	128	128
q7	2162	1845	1825	1825
q8	3237	3404	3361	3361
q9	8696	8709	8856	8709
q10	4241	3898	3884	3884
q11	609	501	507	501
q12	831	622	633	622
q13	16892	3145	3164	3145
q14	312	287	270	270
q15	525	488	491	488
q16	498	450	440	440
q17	1825	1500	1478	1478
q18	7811	7701	7579	7579
q19	1688	1594	1602	1594
q20	2014	1806	1779	1779
q21	11527	4883	4677	4677
q22	617	533	529	529
Total cold run time: 79050 ms
Total hot run time: 55732 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171655 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ddedf023ff725d46a9e84d3ce4ba83b43a44c3c, data reload: false

query1	924	388	365	365
query2	6459	2390	2250	2250
query3	6642	206	203	203
query4	18848	17398	17309	17309
query5	4134	410	417	410
query6	237	154	155	154
query7	4574	297	285	285
query8	294	268	259	259
query9	8548	2350	2343	2343
query10	460	281	260	260
query11	10576	10169	10015	10015
query12	137	90	90	90
query13	1648	376	342	342
query14	9190	7471	6806	6806
query15	225	186	181	181
query16	7662	263	257	257
query17	1546	503	495	495
query18	1630	266	272	266
query19	195	148	153	148
query20	99	86	91	86
query21	199	131	129	129
query22	4185	3967	4132	3967
query23	33597	33172	33352	33172
query24	6871	2958	2765	2765
query25	568	343	358	343
query26	703	155	170	155
query27	2107	301	311	301
query28	3629	2037	2045	2037
query29	855	610	593	593
query30	240	150	149	149
query31	953	771	755	755
query32	92	51	51	51
query33	494	270	254	254
query34	841	476	479	476
query35	675	624	604	604
query36	1066	906	873	873
query37	107	66	68	66
query38	2884	2756	2765	2756
query39	844	809	808	808
query40	208	131	128	128
query41	56	54	51	51
query42	101	98	99	98
query43	554	561	537	537
query44	1033	745	721	721
query45	183	173	171	171
query46	1043	719	684	684
query47	1887	1792	1814	1792
query48	352	289	303	289
query49	761	374	381	374
query50	770	380	381	380
query51	6840	6791	6862	6791
query52	108	89	89	89
query53	362	289	289	289
query54	512	421	421	421
query55	84	70	70	70
query56	253	240	245	240
query57	1134	1050	1038	1038
query58	237	207	212	207
query59	3443	3268	3019	3019
query60	262	249	253	249
query61	88	86	86	86
query62	555	450	461	450
query63	306	279	288	279
query64	8403	2263	1718	1718
query65	3173	3096	3166	3096
query66	807	328	323	323
query67	15345	14923	14883	14883
query68	4525	531	533	531
query69	434	256	269	256
query70	1109	1108	1067	1067
query71	375	258	268	258
query72	6958	5382	5291	5291
query73	715	315	315	315
query74	6097	5737	5628	5628
query75	3301	2660	2630	2630
query76	2261	1005	961	961
query77	383	265	261	261
query78	10344	9940	9690	9690
query79	2560	509	499	499
query80	1075	432	430	430
query81	522	222	218	218
query82	737	90	90	90
query83	249	171	168	168
query84	246	85	82	82
query85	1228	264	264	264
query86	496	324	311	311
query87	3326	3121	3148	3121
query88	4147	2354	2341	2341
query89	470	377	376	376
query90	2104	194	193	193
query91	123	96	93	93
query92	58	48	49	48
query93	2013	498	485	485
query94	1138	185	236	185
query95	406	301	313	301
query96	589	266	259	259
query97	3232	3001	3030	3001
query98	243	216	206	206
query99	1146	877	845	845
Total cold run time: 256408 ms
Total hot run time: 171655 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ddedf023ff725d46a9e84d3ce4ba83b43a44c3c, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.04
query4	1.68	0.08	0.08
query5	0.49	0.48	0.52
query6	1.12	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.50
query10	0.55	0.55	0.55
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	0.81	0.76	0.78
query15	0.85	0.82	0.81
query16	0.36	0.35	0.40
query17	0.98	0.95	0.95
query18	0.19	0.27	0.25
query19	1.81	1.67	1.71
query20	0.02	0.01	0.00
query21	15.73	0.67	0.65
query22	4.77	6.30	1.92
query23	18.33	1.44	1.33
query24	1.84	0.24	0.22
query25	0.14	0.08	0.09
query26	0.27	0.17	0.17
query27	0.08	0.08	0.07
query28	13.26	1.03	1.00
query29	13.15	3.35	3.29
query30	0.23	0.05	0.06
query31	2.89	0.38	0.40
query32	3.26	0.47	0.46
query33	2.87	2.92	2.98
query34	17.04	4.54	4.46
query35	4.53	4.51	4.57
query36	0.74	0.49	0.47
query37	0.18	0.16	0.16
query38	0.17	0.16	0.15
query39	0.05	0.03	0.04
query40	0.16	0.13	0.15
query41	0.09	0.04	0.04
query42	0.05	0.04	0.04
query43	0.04	0.04	0.05
Total cold run time: 110.6 s
Total hot run time: 30.69 s

@yongjinhou yongjinhou force-pushed the cast-str-to-date branch 2 times, most recently from 4a9094d to f9f7db0 Compare May 30, 2024 06:44
@yongjinhou
Copy link
Contributor Author

run buildall

@yongjinhou
Copy link
Contributor Author

run buildall

@yongjinhou
Copy link
Contributor Author

run performance

@yongjinhou
Copy link
Contributor Author

run p0

@doris-robot
Copy link

TPC-H: Total hot run time: 40485 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2434659b6020b10a18339ce7220a772695b6b7ef, data reload: false

------ Round 1 ----------------------------------
q1	18009	4604	4321	4321
q2	2404	201	196	196
q3	11071	1158	1210	1158
q4	10551	811	802	802
q5	7524	2724	2565	2565
q6	223	135	136	135
q7	965	605	601	601
q8	9259	2064	2090	2064
q9	9276	6497	6474	6474
q10	8845	3709	3665	3665
q11	445	243	239	239
q12	449	213	213	213
q13	17779	2976	2960	2960
q14	262	210	223	210
q15	523	460	466	460
q16	541	379	378	378
q17	949	702	649	649
q18	8094	7502	7468	7468
q19	4724	1550	1586	1550
q20	640	302	298	298
q21	4901	3771	3757	3757
q22	379	322	323	322
Total cold run time: 117813 ms
Total hot run time: 40485 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4350	4310	4192	4192
q2	366	261	264	261
q3	2999	2738	2691	2691
q4	1849	1545	1617	1545
q5	5218	5278	5305	5278
q6	208	123	123	123
q7	2119	1687	1776	1687
q8	3246	3295	3294	3294
q9	8311	8341	8330	8330
q10	3870	3678	3661	3661
q11	589	493	485	485
q12	755	586	562	562
q13	17370	2962	2982	2962
q14	297	274	273	273
q15	526	470	469	469
q16	474	421	408	408
q17	1747	1482	1483	1482
q18	7676	7541	7434	7434
q19	3998	1570	1568	1568
q20	2007	1754	1745	1745
q21	4869	4793	4769	4769
q22	603	554	515	515
Total cold run time: 73447 ms
Total hot run time: 53734 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169286 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2434659b6020b10a18339ce7220a772695b6b7ef, data reload: false

query1	927	389	394	389
query2	6478	2300	2315	2300
query3	6667	218	223	218
query4	19189	17379	17257	17257
query5	4236	440	439	439
query6	262	175	171	171
query7	4589	307	307	307
query8	320	294	296	294
query9	8699	2449	2432	2432
query10	465	290	271	271
query11	10357	10086	10027	10027
query12	136	93	91	91
query13	1659	376	383	376
query14	9432	6831	6286	6286
query15	233	182	189	182
query16	7816	275	266	266
query17	1576	543	528	528
query18	1920	283	276	276
query19	202	165	163	163
query20	102	88	88	88
query21	195	131	134	131
query22	4259	4007	3937	3937
query23	33573	32978	32937	32937
query24	12174	2883	2876	2876
query25	696	389	377	377
query26	1822	157	158	157
query27	3033	321	320	320
query28	7676	2092	2109	2092
query29	1148	617	613	613
query30	286	155	153	153
query31	950	765	748	748
query32	103	57	57	57
query33	794	280	276	276
query34	1002	477	489	477
query35	763	627	633	627
query36	1085	912	898	898
query37	157	70	68	68
query38	2913	2770	2795	2770
query39	860	781	807	781
query40	282	131	130	130
query41	59	55	57	55
query42	104	101	97	97
query43	574	549	558	549
query44	1234	752	768	752
query45	185	167	170	167
query46	1073	733	745	733
query47	1851	1752	1765	1752
query48	369	305	301	301
query49	1200	403	413	403
query50	777	396	382	382
query51	6804	6548	6587	6548
query52	108	90	87	87
query53	352	291	287	287
query54	950	448	437	437
query55	76	77	75	75
query56	306	255	259	255
query57	1169	1029	1034	1029
query58	244	221	217	217
query59	3269	3042	3122	3042
query60	308	278	280	278
query61	113	111	107	107
query62	662	433	458	433
query63	317	291	289	289
query64	9983	2493	1864	1864
query65	3224	3091	3112	3091
query66	1370	352	374	352
query67	15094	14872	14817	14817
query68	4646	553	548	548
query69	456	286	291	286
query70	1126	1134	1115	1115
query71	422	269	276	269
query72	7486	4585	2771	2771
query73	708	329	328	328
query74	6004	5532	5668	5532
query75	3400	2631	2653	2631
query76	2633	1073	988	988
query77	415	284	280	280
query78	10261	9737	9610	9610
query79	1999	512	520	512
query80	1053	456	452	452
query81	514	223	222	222
query82	647	97	98	97
query83	249	179	193	179
query84	247	91	87	87
query85	1814	329	332	329
query86	488	306	317	306
query87	3294	3134	3107	3107
query88	4284	2377	2382	2377
query89	487	395	376	376
query90	2002	193	197	193
query91	145	119	120	119
query92	69	54	55	54
query93	2302	525	506	506
query94	1306	204	206	204
query95	425	337	333	333
query96	596	270	268	268
query97	3183	2973	3064	2973
query98	243	237	225	225
query99	1162	847	824	824
Total cold run time: 274877 ms
Total hot run time: 169286 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.32 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2434659b6020b10a18339ce7220a772695b6b7ef, data reload: false

query1	0.03	0.03	0.04
query2	0.09	0.04	0.03
query3	0.23	0.05	0.05
query4	1.68	0.06	0.06
query5	0.48	0.52	0.50
query6	1.13	0.72	0.71
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.53	0.50	0.48
query10	0.55	0.55	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.60
query14	0.77	0.77	0.79
query15	0.82	0.80	0.81
query16	0.37	0.35	0.37
query17	1.01	0.94	0.92
query18	0.22	0.23	0.24
query19	1.77	1.68	1.74
query20	0.01	0.01	0.01
query21	15.68	0.65	0.65
query22	4.23	7.40	1.84
query23	18.34	1.36	1.29
query24	1.78	0.22	0.20
query25	0.16	0.08	0.09
query26	0.27	0.16	0.16
query27	0.08	0.08	0.08
query28	13.38	1.00	1.00
query29	12.77	3.27	3.24
query30	0.24	0.06	0.05
query31	2.88	0.39	0.37
query32	3.31	0.47	0.46
query33	2.87	2.85	2.92
query34	17.08	4.48	4.49
query35	4.50	4.50	4.56
query36	0.64	0.46	0.46
query37	0.17	0.15	0.16
query38	0.16	0.14	0.14
query39	0.04	0.04	0.03
query40	0.16	0.15	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.03	0.03	0.04
Total cold run time: 109.57 s
Total hot run time: 30.32 s

@yongjinhou
Copy link
Contributor Author

run p0

@zclllyybb
Copy link
Contributor

what's the behaviour in other db system?

zclllyybb
zclllyybb suggested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a strong basis to prove that this change is necessary.

@yongjinhou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40949 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e5d6e1b45297599699dd56efbff56dc50e711ee6, data reload: false

------ Round 1 ----------------------------------
q1	17615	4356	4279	4279
q2	2024	196	200	196
q3	10437	1249	1124	1124
q4	10195	874	811	811
q5	7478	2678	2731	2678
q6	236	131	136	131
q7	960	636	623	623
q8	9213	2104	2093	2093
q9	9385	6769	6688	6688
q10	9465	3889	3843	3843
q11	441	246	248	246
q12	449	225	228	225
q13	17425	3226	3245	3226
q14	267	215	219	215
q15	512	480	462	462
q16	513	414	409	409
q17	989	694	645	645
q18	8406	7994	7785	7785
q19	4907	1434	1358	1358
q20	678	327	326	326
q21	5189	3366	3248	3248
q22	419	338	339	338
Total cold run time: 117203 ms
Total hot run time: 40949 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4610	4443	4386	4386
q2	369	269	265	265
q3	3095	2891	2972	2891
q4	2028	1623	1581	1581
q5	5367	5531	5483	5483
q6	229	130	128	128
q7	2203	1823	1790	1790
q8	3221	3377	3395	3377
q9	8600	8520	8698	8520
q10	4106	3824	3804	3804
q11	581	488	485	485
q12	771	590	617	590
q13	15901	3138	3183	3138
q14	304	273	279	273
q15	518	483	484	483
q16	490	434	438	434
q17	1816	1495	1471	1471
q18	8099	7646	7330	7330
q19	1736	1602	1657	1602
q20	3024	1789	1791	1789
q21	8392	4890	4627	4627
q22	745	540	541	540
Total cold run time: 76205 ms
Total hot run time: 54987 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173565 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e5d6e1b45297599699dd56efbff56dc50e711ee6, data reload: false

query1	923	386	371	371
query2	6450	2425	2277	2277
query3	6640	205	206	205
query4	19912	17227	17445	17227
query5	4156	470	461	461
query6	244	157	161	157
query7	4588	301	306	301
query8	316	292	286	286
query9	8460	2382	2360	2360
query10	460	312	285	285
query11	10508	10019	10066	10019
query12	136	91	93	91
query13	1673	385	372	372
query14	10354	7773	7780	7773
query15	254	191	183	183
query16	7801	262	262	262
query17	1714	523	525	523
query18	1898	278	276	276
query19	204	160	161	160
query20	96	91	109	91
query21	204	143	135	135
query22	4277	4136	4029	4029
query23	33851	32818	33099	32818
query24	10918	2849	2856	2849
query25	634	381	365	365
query26	1170	158	162	158
query27	2988	325	334	325
query28	7436	2056	2055	2055
query29	885	618	604	604
query30	227	151	151	151
query31	946	777	726	726
query32	96	55	55	55
query33	758	285	275	275
query34	957	500	478	478
query35	730	636	625	625
query36	1091	930	922	922
query37	149	71	71	71
query38	2886	2753	2730	2730
query39	860	797	788	788
query40	222	133	132	132
query41	59	56	54	54
query42	121	101	100	100
query43	580	566	534	534
query44	1199	780	757	757
query45	196	167	174	167
query46	1070	738	766	738
query47	1833	1744	1746	1744
query48	383	302	310	302
query49	883	414	419	414
query50	794	407	402	402
query51	6904	6855	6754	6754
query52	111	95	93	93
query53	359	295	284	284
query54	843	462	453	453
query55	73	75	71	71
query56	279	257	270	257
query57	1108	1028	1082	1028
query58	267	249	240	240
query59	3503	3249	3237	3237
query60	314	273	275	273
query61	92	91	89	89
query62	612	446	450	446
query63	332	291	296	291
query64	8906	2276	1796	1796
query65	3178	3059	3146	3059
query66	794	346	334	334
query67	15479	14899	14788	14788
query68	4524	573	563	563
query69	600	484	413	413
query70	1171	1120	1099	1099
query71	396	297	314	297
query72	7059	5213	5417	5213
query73	768	329	325	325
query74	5869	5509	5479	5479
query75	3306	2658	2645	2645
query76	2368	915	918	915
query77	446	296	315	296
query78	10308	10020	9884	9884
query79	2517	576	519	519
query80	1151	485	468	468
query81	567	218	226	218
query82	781	106	109	106
query83	242	174	172	172
query84	244	90	87	87
query85	1487	274	265	265
query86	499	321	322	321
query87	3311	3119	3088	3088
query88	4055	2444	2464	2444
query89	485	406	389	389
query90	1839	191	190	190
query91	127	97	99	97
query92	58	51	51	51
query93	1815	528	509	509
query94	1240	196	188	188
query95	425	325	368	325
query96	593	272	273	272
query97	3166	3017	2991	2991
query98	245	217	211	211
query99	1197	852	849	849
Total cold run time: 271203 ms
Total hot run time: 173565 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.03 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e5d6e1b45297599699dd56efbff56dc50e711ee6, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.05	0.05
query4	1.67	0.08	0.08
query5	0.49	0.47	0.51
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.06	0.04	0.04
query9	0.53	0.49	0.48
query10	0.55	0.55	0.55
query11	0.14	0.11	0.11
query12	0.16	0.12	0.12
query13	0.59	0.58	0.61
query14	0.76	0.78	0.77
query15	0.83	0.83	0.81
query16	0.37	0.35	0.36
query17	1.00	0.95	1.01
query18	0.20	0.26	0.22
query19	1.76	1.80	1.71
query20	0.02	0.01	0.02
query21	15.49	0.70	0.67
query22	4.19	6.42	2.48
query23	18.25	1.42	1.31
query24	1.30	0.45	0.21
query25	0.15	0.10	0.08
query26	0.27	0.17	0.18
query27	0.07	0.08	0.08
query28	13.34	1.01	1.00
query29	13.25	3.30	3.24
query30	0.25	0.06	0.06
query31	2.85	0.39	0.39
query32	3.28	0.48	0.47
query33	2.95	2.86	2.98
query34	17.12	4.42	4.40
query35	4.46	4.47	4.64
query36	0.65	0.45	0.46
query37	0.17	0.16	0.15
query38	0.15	0.15	0.14
query39	0.05	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.03
Total cold run time: 109.24 s
Total hot run time: 31.03 s

@yongjinhou
Copy link
Contributor Author

run p0

1 similar comment
@yongjinhou
Copy link
Contributor Author

run p0

chenlinzhong
chenlinzhong approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@chenlinzhong chenlinzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongjinhou
Copy link
Contributor Author

Consistent with mysql.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by anyone and no changes requested.

@yongjinhou
Copy link
Contributor Author

run Need_2_Approval

@chenlinzhong chenlinzhong merged commit c8985dc into apache:master Jun 5, 2024
27 of 28 checks passed
yongjinhou added a commit to yongjinhou/doris that referenced this pull request Jun 5, 2024
@yongjinhou
[Bug](function) Fix function for cast string as date/datetime (apache…
a970162 
…#35637)

Issue Number: close apache#35635

<!--Describe your changes.-->
Cast rules：Consistent with mysql.
String：Date
The first part is 1-digit x: 000x-month-day
The first part is 2-digit xy: 20xy-month-day / 19xy-month-day
The first part is 3-digit xyz: 20xy-0z-day / 19xy-0z-day
The first part is 4-digit xyzw: xyzw-month-day
@yongjinhou yongjinhou mentioned this pull request Jun 6, 2024
Merged
morningman pushed a commit that referenced this pull request Jun 6, 2024
@yongjinhou
[Bug](function) Fix function for cast string as date/datetime (#35637) (
83409fc 
#35931)

cherry-pick #35637 from master to branch-2.0
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
@yongjinhou @dataroaring
[Bug](function) Fix function for cast string as date/datetime (#35637)
effa328 
## Proposed changes

Issue Number: close #35635

<!--Describe your changes.-->
Cast rules：Consistent with mysql.
String：Date
The first part is 1-digit x: 000x-month-day
The first part is 2-digit xy: 20xy-month-day / 19xy-month-day
The first part is 3-digit xyz: 20xy-0z-day / 19xy-0z-day
The first part is 4-digit xyzw: xyzw-month-day
This was referenced Jul 16, 2024
Closed
Merged
yiguolei pushed a commit that referenced this pull request Jul 16, 2024
@yongjinhou
[Bug](function) Fix function for cast string as date/datetime (#35637) (
638d4b6 
#37891)

## Proposed changes

Issue Number: close #35635
cherry-pick #35637 from master to
branch-2.1

<!--Describe your changes.-->
Cast rules：Consistent with mysql.
String：Date
The first part is 1-digit x: 000x-month-day
The first part is 2-digit xy: 20xy-month-day / 19xy-month-day The first
part is 3-digit xyz: 20xy-0z-day / 19xy-0z-day The first part is 4-digit
xyzw: xyzw-month-day

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
Open
1 task
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@yongjinhou
[Bug](function) Fix function for cast string as date/datetime (apache…
216a745 
…#35637) (apache#35931)

cherry-pick apache#35637 from master to branch-2.0
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Dec 27, 2024
Merged
16 tasks
englefly pushed a commit that referenced this pull request Dec 30, 2024
@LiBinfeng-01
[fix](Nereids) fix cast string to date (#46065)
2466d08 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #35637 

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
@LiBinfeng-01
[fix](Nereids) fix cast string to date (#46065)
d386036 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #35637 

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Jan 7, 2025
@LiBinfeng-01
[fix](Nereids) fix cast string to date (apache#46065)
edc5c60 
Issue Number: close #xxx

Related PR: apache#35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Jan 7, 2025
Merged
16 tasks
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Jan 9, 2025
@LiBinfeng-01
[fix](Nereids) fix cast string to date (apache#46065)
393ff40 
Issue Number: close #xxx

Related PR: apache#35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Jan 9, 2025
@LiBinfeng-01
[fix](Nereids) fix cast string to date (apache#46065)
11bc6ab 
Issue Number: close #xxx

Related PR: apache#35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
morrySnow pushed a commit that referenced this pull request Jan 9, 2025
@LiBinfeng-01
branch-2.1: [fix](Nereids) fix cast string to date #46065 (#46526)
4f41bad 
pick: #46065

Related PR: #35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Jan 14, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenlinzhong chenlinzhong chenlinzhong approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.12-merged dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The cast function does not convert string to date/datetime as expected
8 participants
@yongjinhou @doris-robot @zclllyybb @chenlinzhong @morningman @yiguolei @dataroaring @morrySnow