Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1][improvement](sqlserver catalog) Configurable whether to use encrypt when connecting to SQL Server using the catalog #36971

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Jun 28, 2024

pick (#36659)
pick #37015
In previous versions, we used druid as the default JDBC connection pool, which can use custom decryption to parse the certificate when SQL Server encryption is turned on. However, in the new version, after changing HikariCP as the default connection pool, the SQLServer certificate cannot be parsed, so encryption needs to be turned off for normal use. Therefore, a parameter is added to decide whether to disable SQLServer encryption. It is not disabled by default.

Proposed changes

Issue Number: close #xxx

…when connecting to SQL Server using the catalog (apache#36659)

In previous versions, we used druid as the default JDBC connection pool,
which can use custom decryption to parse the certificate when SQL Server
encryption is turned on. However, in the new version, after changing
HikariCP as the default connection pool, the SQLServer certificate
cannot be parsed, so encryption needs to be turned off for normal use.
Therefore, a parameter is added to decide whether to disable SQLServer
encryption. It is not disabled by default.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented Jun 28, 2024

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented Jun 28, 2024

run buildall

1 similar comment
@zy-kkk
Copy link
Member Author

zy-kkk commented Jul 1, 2024

run buildall

@zy-kkk zy-kkk merged commit 3f382b7 into apache:branch-2.1 Jul 2, 2024
21 of 22 checks passed
@zy-kkk zy-kkk deleted the sqlserver_encrypt_false_21 branch July 2, 2024 02:14
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants