[fix](auth)fix fe can not restart when replay create row policy log #37342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zddr
changed the title
|
run buildall |
TPC-H: Total hot run time: 39747 ms |
TPC-DS: Total hot run time: 172719 ms |
ClickBench: Total hot run time: 30.67 s |
morrySnow
reviewed
Jul 5, 2024
| @@ -102,6 +102,8 @@ public class RowPolicy extends Policy implements RowFilterPolicy { | |||
| **/ | |||
| @SerializedName(value = "originStmt") | |||
| private String originStmt; | |||
| @SerializedName(value = "stmtIdx") | |||
| private int stmtIdx; | |||
There was a problem hiding this comment.
what will stmtIdx be when do deserialization if no stmtIdx in json
There was a problem hiding this comment.
will be default 0,we only support stmtIdx is 0
| @@ -218,7 +225,7 @@ public boolean isInvalid() { | |||
| public Expression getFilterExpression() throws AnalysisException { | |||
| NereidsParser nereidsParser = new NereidsParser(); | |||
| String sql = getOriginStmt(); | |||
| CreatePolicyCommand command = (CreatePolicyCommand) nereidsParser.parseSingle(sql); | |||
| CreatePolicyCommand command = (CreatePolicyCommand) nereidsParser.parseMultiple(sql).get(stmtIdx).first; | |||
There was a problem hiding this comment.
check out of bound error?
|
run buildall |
|
run performance |
TPC-H: Total hot run time: 39818 ms |
TPC-DS: Total hot run time: 173737 ms |
ClickBench: Total hot run time: 30.33 s |
|
run buildall |
morrySnow
approved these changes
Jul 8, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39524 ms |
TPC-DS: Total hot run time: 173545 ms |
ClickBench: Total hot run time: 31.26 s |
xiaokang
pushed a commit
that referenced
this pull request
Jul 9, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 9, 2024
…37342) When executing two SQL statements simultaneously,such as ``` DROP ROW POLICY IF EXISTS test_row_policy_3 on zd.user1;CREATE ROW POLICY test_row_policy_3 ON zd.user1 AS RESTRICTIVE TO role role1 USING (k1 in (1) or k2 in (2)); ``` fe will can not restart ``` Caused by: java.lang.ClassCastException: org.apache.doris.analysis.DropPolicyStmt cannot be cast to org.apache.doris.analysis.CreatePolicyStmt at org.apache.doris.policy.RowPolicy.gsonPostProcess(RowPolicy.java:169) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.persist.gson.GsonUtils$PostProcessTypeAdapterFactory$1.read(GsonUtils.java:640) ~[doris-fe.jar:1.2-SNAPSHOT] at com.google.gson.TypeAdapter.fromJsonTree(TypeAdapter.java:299) ~[gson-2.10.1.jar:?] ... 14 more ``` fix: - setOrigStmt use split sql instead of full sql - store index to cope with segmentation failure
zddr
added a commit
to zddr/incubator-doris
that referenced
this pull request
Jul 15, 2024
…pache#37342) When executing two SQL statements simultaneously,such as ``` DROP ROW POLICY IF EXISTS test_row_policy_3 on zd.user1;CREATE ROW POLICY test_row_policy_3 ON zd.user1 AS RESTRICTIVE TO role role1 USING (k1 in (1) or k2 in (2)); ``` fe will can not restart ``` Caused by: java.lang.ClassCastException: org.apache.doris.analysis.DropPolicyStmt cannot be cast to org.apache.doris.analysis.CreatePolicyStmt at org.apache.doris.policy.RowPolicy.gsonPostProcess(RowPolicy.java:169) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.persist.gson.GsonUtils$PostProcessTypeAdapterFactory$1.read(GsonUtils.java:640) ~[doris-fe.jar:1.2-SNAPSHOT] at com.google.gson.TypeAdapter.fromJsonTree(TypeAdapter.java:299) ~[gson-2.10.1.jar:?] ... 14 more ``` fix: - setOrigStmt use split sql instead of full sql - store index to cope with segmentation failure
yiguolei
pushed a commit
that referenced
this pull request
Jul 16, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing two SQL statements simultaneously,such as
fe will can not restart
fix: