[fix](function) Fix wrong result of week/yearweek in constant folding #37376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 39684 ms |
TPC-DS: Total hot run time: 173720 ms |
ClickBench: Total hot run time: 30.61 s |
zhangstar333
approved these changes
Jul 8, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
Mryange
approved these changes
Jul 8, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…#37376) ## Proposed changes Issue Number: close #xxx Java doesn't support the calculation of `0000-01-01`(0000 year is 1 B.C. which ISO-8601 defines). so some of our calc was wrong in FE. now fixed them. new result: ```sql mysql> select week('0000-01-01', 0),week('0000-01-01', 1),week('0000-01-01', 2),week('0000-01-01', 3),week('0000-01-01', 4), week('0000-01-01', 5), week('0000-01-01', 6), week('0000-01-01', 7); +------+------+------+------+------+------+------+------+ | 1 | 0 | 1 | 52 | 1 | 0 | 1 | 52 | +------+------+------+------+------+------+------+------+ | 1 | 0 | 1 | 52 | 1 | 0 | 1 | 52 | +------+------+------+------+------+------+------+------+ 1 row in set (0.10 sec) mysql> select week('0000-01-02', 0),week('0000-01-02', 1),week('0000-01-02', 2),week('0000-01-02', 3),week('0000-01-02', 4), week('0000-01-02', 5), week('0000-01-02', 6), week('0000-01-02', 7); +------+------+------+------+------+------+------+------+ | 1 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 1 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ 1 row in set (0.10 sec) ``` same with `yearweek`
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Feb 7, 2025
…apache#37376) Issue Number: close #xxx Java doesn't support the calculation of `0000-01-01`(0000 year is 1 B.C. which ISO-8601 defines). so some of our calc was wrong in FE. now fixed them. new result: ```sql mysql> select week('0000-01-01', 0),week('0000-01-01', 1),week('0000-01-01', 2),week('0000-01-01', 3),week('0000-01-01', 4), week('0000-01-01', 5), week('0000-01-01', 6), week('0000-01-01', 7); +------+------+------+------+------+------+------+------+ | 1 | 0 | 1 | 52 | 1 | 0 | 1 | 52 | +------+------+------+------+------+------+------+------+ | 1 | 0 | 1 | 52 | 1 | 0 | 1 | 52 | +------+------+------+------+------+------+------+------+ 1 row in set (0.10 sec) mysql> select week('0000-01-02', 0),week('0000-01-02', 1),week('0000-01-02', 2),week('0000-01-02', 3),week('0000-01-02', 4), week('0000-01-02', 5), week('0000-01-02', 6), week('0000-01-02', 7); +------+------+------+------+------+------+------+------+ | 1 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 1 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ 1 row in set (0.10 sec) ``` same with `yearweek`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Java doesn't support the calculation of
0000-01-01(0000 year is 1 B.C. which ISO-8601 defines). so some of our calc was wrong in FE. now fixed them.new result:
same with
yearweek