[fix](load) The NodeChannel should be canceled when failed to add block #37500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
gavinchou
approved these changes
Jul 8, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
kaijchen
approved these changes
Jul 8, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39573 ms |
TPC-DS: Total hot run time: 173557 ms |
ClickBench: Total hot run time: 30.72 s |
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 9, 2024
…ck (apache#37500) ## Proposed changes F20240704 15:35:33.724236 2556376 vtablet_writer.cpp:614] Check failed: block.rows() == request->tablet_ids_size() block rows: 12192, tablet_ids_size: 8128 *** Check failure stack trace: *** @ 0x5612d9ebf696 google::LogMessage::SendToLog() @ 0x5612d9ebc0e0 google::LogMessage::Flush() @ 0x5612d9ebfed9 google::LogMessageFatal::~LogMessageFatal() @ 0x5612d96a1770 doris::vectorized::VNodeChannel::try_send_pending_block() @ 0x5612d0541e98 doris::ThreadPool::dispatch_thread() @ 0x5612d0537251 doris::Thread::supervise_thread() @ 0x7f02d4061ac3 (unknown) @ 0x7f02d40f3850 (unknown) @ (nil) (unknown) The reason for this issue is due to a failed return from `append_to_block_by_selector`. The reason for the failure here is that the memory exceeded the limit. The previous column append was successful, while the subsequent columns failed to allocate memory. The failure was directly returned from here, and the subsequent _cur_add_block_request was not executed. However, if the NodeChannel is not cancelled, the next add block will succeed, causing the block's rows to have an additional batch size (4064) compared to the tablet id's size, ultimately triggering the failure of the check. <!--Describe your changes.-->
liaoxin01
added a commit
that referenced
this pull request
Jul 9, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…ck (#37500) ## Proposed changes F20240704 15:35:33.724236 2556376 vtablet_writer.cpp:614] Check failed: block.rows() == request->tablet_ids_size() block rows: 12192, tablet_ids_size: 8128 *** Check failure stack trace: *** @ 0x5612d9ebf696 google::LogMessage::SendToLog() @ 0x5612d9ebc0e0 google::LogMessage::Flush() @ 0x5612d9ebfed9 google::LogMessageFatal::~LogMessageFatal() @ 0x5612d96a1770 doris::vectorized::VNodeChannel::try_send_pending_block() @ 0x5612d0541e98 doris::ThreadPool::dispatch_thread() @ 0x5612d0537251 doris::Thread::supervise_thread() @ 0x7f02d4061ac3 (unknown) @ 0x7f02d40f3850 (unknown) @ (nil) (unknown) The reason for this issue is due to a failed return from `append_to_block_by_selector`. The reason for the failure here is that the memory exceeded the limit. The previous column append was successful, while the subsequent columns failed to allocate memory. The failure was directly returned from here, and the subsequent _cur_add_block_request was not executed. However, if the NodeChannel is not cancelled, the next add block will succeed, causing the block's rows to have an additional batch size (4064) compared to the tablet id's size, ultimately triggering the failure of the check. <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
F20240704 15:35:33.724236 2556376 vtablet_writer.cpp:614] Check failed: block.rows() == request->tablet_ids_size() block rows: 12192, tablet_ids_size: 8128
*** Check failure stack trace: ***
@ 0x5612d9ebf696 google::LogMessage::SendToLog()
@ 0x5612d9ebc0e0 google::LogMessage::Flush()
@ 0x5612d9ebfed9 google::LogMessageFatal::~LogMessageFatal()
@ 0x5612d96a1770 doris::vectorized::VNodeChannel::try_send_pending_block()
@ 0x5612d0541e98 doris::ThreadPool::dispatch_thread()
@ 0x5612d0537251 doris::Thread::supervise_thread()
@ 0x7f02d4061ac3 (unknown)
@ 0x7f02d40f3850 (unknown)
@ (nil) (unknown)
The reason for this issue is due to a failed return from
append_to_block_by_selector. The reason for the failure here is that the memory exceeded the limit. The previous column append was successful, while the subsequent columns failed to allocate memory. The failure was directly returned from here, and the subsequent _cur_add_block_request was not executed.However, if the NodeChannel is not cancelled, the next add block will succeed, causing the block's rows to have an additional batch size (4064) compared to the tablet id's size, ultimately triggering the failure of the check.