[fix](recycler) Fix incorrect mtime convertion in azure obj client #37535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
platoneko
force-pushed
the
fix_azure_mtime
branch
from
fdb34fa to
ec720cd
Compare
gavinchou
previously approved these changes
Jul 9, 2024
| @@ -91,12 +92,15 @@ class AzureListIterator final : public ObjectListIterator { | |||
| DCHECK(!(has_more_ && resp.Blobs.empty())) << has_more_ << ' ' << resp.Blobs.empty(); | |||
| req_.ContinuationToken = std::move(resp.NextPageToken); | |||
| results_.reserve(resp.Blobs.size()); | |||
| const auto unix_epoch = Azure::DateTime(1970, 1, 1); | |||
There was a problem hiding this comment.
/**
* @brief Construct an instance of `%DateTime` from `std::chrono::system_clock::time_point`.
* @param systemTime A value of `std::chrono::system_clock::time_point`.
*
*/
DateTime(std::chrono::system_clock::time_point const& systemTime)
: DateTime(
SystemClockEpoch + std::chrono::duration_cast<duration>(systemTime.time_since_epoch()))
{
}
``
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
gavinchou
reviewed
Jul 9, 2024
platoneko
force-pushed
the
fix_azure_mtime
branch
from
ec720cd to
f0e92ff
Compare
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
platoneko
force-pushed
the
fix_azure_mtime
branch
from
f0e92ff to
b609f0c
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
gavinchou
approved these changes
Jul 12, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
ByteYue
approved these changes
Jul 12, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix incorrect mtime convertion in azure obj client