Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](catalog)Fix internal program error causing client to get stuck #37551

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Jul 9, 2024

Fix incorrect catalog statements or program errors that cause the catalog to be created without an error prompt and instead get stuck

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr
Copy link
Contributor Author

zddr commented Jul 9, 2024

run buildall

1 similar comment
@zddr
Copy link
Contributor Author

zddr commented Jul 10, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39660 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 491200172045abd3703b81398a3f39a21e76cd48, data reload: false

------ Round 1 ----------------------------------
q1	17629	4328	4263	4263
q2	2027	185	182	182
q3	10492	1134	1064	1064
q4	10187	778	814	778
q5	7486	2635	2578	2578
q6	221	138	139	138
q7	953	601	611	601
q8	9250	2033	2066	2033
q9	8766	6981	6464	6464
q10	8961	3744	3719	3719
q11	451	241	246	241
q12	451	226	230	226
q13	17774	2988	2976	2976
q14	269	220	229	220
q15	513	481	494	481
q16	498	380	379	379
q17	952	623	706	623
q18	8045	7411	7419	7411
q19	8048	1489	1445	1445
q20	695	316	334	316
q21	4854	3190	3242	3190
q22	385	334	332	332
Total cold run time: 118907 ms
Total hot run time: 39660 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4421	4298	4278	4278
q2	382	273	282	273
q3	3024	2903	2961	2903
q4	1967	1728	1761	1728
q5	5537	5547	5445	5445
q6	227	135	135	135
q7	2251	1846	1841	1841
q8	3258	3451	3429	3429
q9	8661	8766	8711	8711
q10	4118	3727	3813	3727
q11	613	504	510	504
q12	821	635	620	620
q13	16324	3157	3215	3157
q14	317	269	290	269
q15	537	487	483	483
q16	476	443	424	424
q17	1814	1519	1512	1512
q18	8133	8034	7836	7836
q19	1804	1593	1651	1593
q20	2528	1860	1860	1860
q21	6521	4979	4900	4900
q22	611	515	553	515
Total cold run time: 74345 ms
Total hot run time: 56143 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174348 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 491200172045abd3703b81398a3f39a21e76cd48, data reload: false

query1	917	377	358	358
query2	6463	2388	2361	2361
query3	6645	206	214	206
query4	28350	17364	17066	17066
query5	3769	474	473	473
query6	261	181	171	171
query7	4580	296	288	288
query8	318	288	300	288
query9	8551	2394	2356	2356
query10	434	284	270	270
query11	10795	10229	10193	10193
query12	117	82	82	82
query13	1644	373	377	373
query14	9984	7588	7475	7475
query15	222	181	184	181
query16	7775	299	305	299
query17	1799	562	515	515
query18	1959	292	302	292
query19	197	154	147	147
query20	91	83	81	81
query21	214	124	121	121
query22	4318	4319	4085	4085
query23	33959	33853	34163	33853
query24	11163	2861	2814	2814
query25	572	454	425	425
query26	839	152	147	147
query27	3009	285	282	282
query28	7864	2135	2096	2096
query29	899	656	664	656
query30	250	156	164	156
query31	984	759	787	759
query32	102	57	60	57
query33	800	325	316	316
query34	994	490	502	490
query35	697	582	591	582
query36	1108	936	955	936
query37	133	80	80	80
query38	2861	2740	2740	2740
query39	859	823	828	823
query40	199	125	120	120
query41	53	51	52	51
query42	118	105	100	100
query43	603	527	500	500
query44	1185	732	749	732
query45	198	157	161	157
query46	1068	739	718	718
query47	1846	1765	1764	1764
query48	377	300	300	300
query49	896	416	457	416
query50	790	387	396	387
query51	6866	6799	6744	6744
query52	110	90	92	90
query53	361	285	290	285
query54	870	457	443	443
query55	74	75	73	73
query56	291	269	264	264
query57	1137	1050	1050	1050
query58	259	246	259	246
query59	3510	3363	3413	3363
query60	302	289	288	288
query61	95	96	95	95
query62	791	648	648	648
query63	313	290	302	290
query64	9403	2273	1634	1634
query65	3158	3057	3098	3057
query66	748	328	325	325
query67	15687	15243	15025	15025
query68	4484	526	539	526
query69	598	409	348	348
query70	1113	1043	1073	1043
query71	420	283	272	272
query72	7249	5270	5236	5236
query73	751	319	321	319
query74	5909	5515	5533	5515
query75	3374	2712	2696	2696
query76	2741	969	1005	969
query77	604	304	310	304
query78	11017	9187	8809	8809
query79	3235	517	510	510
query80	1508	473	472	472
query81	596	220	223	220
query82	688	135	134	134
query83	343	170	174	170
query84	278	85	91	85
query85	1210	375	303	303
query86	484	328	318	318
query87	3274	3094	3123	3094
query88	4864	2453	2455	2453
query89	498	384	379	379
query90	1873	191	188	188
query91	129	100	101	100
query92	64	51	49	49
query93	4644	509	505	505
query94	1200	214	203	203
query95	392	310	307	307
query96	597	271	280	271
query97	3196	3049	3043	3043
query98	221	209	195	195
query99	1587	1254	1269	1254
Total cold run time: 286945 ms
Total hot run time: 174348 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 491200172045abd3703b81398a3f39a21e76cd48, data reload: false

query1	0.03	0.03	0.04
query2	0.08	0.03	0.04
query3	0.22	0.04	0.04
query4	1.68	0.07	0.07
query5	0.49	0.48	0.49
query6	1.14	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.50	0.49
query10	0.55	0.54	0.55
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.59	0.58	0.58
query14	0.76	0.78	0.77
query15	0.84	0.82	0.82
query16	0.37	0.37	0.37
query17	1.01	0.96	1.05
query18	0.24	0.22	0.23
query19	1.82	1.68	1.71
query20	0.01	0.00	0.01
query21	15.39	0.78	0.67
query22	4.39	7.60	1.84
query23	18.29	1.33	1.41
query24	2.13	0.25	0.22
query25	0.15	0.08	0.08
query26	0.30	0.21	0.21
query27	0.45	0.22	0.23
query28	13.23	1.02	1.01
query29	12.62	3.36	3.33
query30	0.25	0.06	0.05
query31	2.88	0.39	0.38
query32	3.27	0.48	0.47
query33	2.88	2.94	2.91
query34	17.11	4.33	4.40
query35	4.41	4.43	4.48
query36	0.65	0.49	0.48
query37	0.20	0.15	0.15
query38	0.15	0.14	0.14
query39	0.04	0.03	0.03
query40	0.16	0.12	0.11
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.89 s
Total hot run time: 30.6 s

@zddr
Copy link
Contributor Author

zddr commented Jul 10, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39627 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 73cde74617dcfb810e57e94bff82261bd58291a3, data reload: false

------ Round 1 ----------------------------------
q1	18189	4479	4321	4321
q2	2477	194	211	194
q3	10954	1158	1047	1047
q4	10932	756	843	756
q5	7522	2798	2711	2711
q6	226	145	144	144
q7	974	607	621	607
q8	9505	2074	2041	2041
q9	9019	6480	6421	6421
q10	8941	3740	3714	3714
q11	447	233	232	232
q12	395	227	219	219
q13	17773	2981	2975	2975
q14	263	216	230	216
q15	534	485	494	485
q16	487	378	379	378
q17	956	570	683	570
q18	8067	7557	7361	7361
q19	4172	1532	1471	1471
q20	667	323	327	323
q21	4933	3099	3859	3099
q22	396	342	342	342
Total cold run time: 117829 ms
Total hot run time: 39627 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4407	4314	4217	4217
q2	385	270	265	265
q3	2980	2795	2763	2763
q4	1891	1528	1608	1528
q5	5271	5301	5317	5301
q6	224	137	132	132
q7	2126	1800	1761	1761
q8	3167	3346	3325	3325
q9	8312	8294	8347	8294
q10	3862	3650	3649	3649
q11	573	511	498	498
q12	795	615	605	605
q13	16626	2981	2976	2976
q14	302	259	257	257
q15	518	483	486	483
q16	472	410	428	410
q17	1785	1479	1477	1477
q18	7557	7457	7315	7315
q19	1720	1627	1550	1550
q20	2006	1816	1778	1778
q21	4885	4736	4761	4736
q22	608	555	543	543
Total cold run time: 70472 ms
Total hot run time: 53863 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173545 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 73cde74617dcfb810e57e94bff82261bd58291a3, data reload: false

query1	914	367	370	367
query2	6453	2415	2391	2391
query3	6652	205	215	205
query4	27691	17412	17332	17332
query5	4190	465	476	465
query6	270	185	194	185
query7	4585	298	294	294
query8	329	317	297	297
query9	8660	2384	2371	2371
query10	443	296	280	280
query11	10617	10075	9928	9928
query12	131	90	80	80
query13	1628	384	370	370
query14	10112	7760	7941	7760
query15	263	190	186	186
query16	7972	323	309	309
query17	1975	550	535	535
query18	1981	273	277	273
query19	194	145	155	145
query20	97	79	103	79
query21	201	128	127	127
query22	4359	4093	4156	4093
query23	33748	32997	33328	32997
query24	12019	2780	2846	2780
query25	663	360	373	360
query26	1776	159	152	152
query27	2881	271	286	271
query28	7719	2050	2046	2046
query29	1060	648	611	611
query30	281	150	150	150
query31	971	734	750	734
query32	92	51	52	51
query33	764	308	302	302
query34	966	527	497	497
query35	694	574	559	559
query36	1088	939	924	924
query37	161	83	75	75
query38	2846	2753	2716	2716
query39	862	789	806	789
query40	282	121	119	119
query41	54	52	50	50
query42	113	97	101	97
query43	606	567	534	534
query44	1239	759	736	736
query45	191	163	164	163
query46	1082	706	734	706
query47	1868	1758	1748	1748
query48	364	299	311	299
query49	1162	417	423	417
query50	769	406	411	406
query51	6896	6810	6709	6709
query52	110	90	100	90
query53	360	297	302	297
query54	935	453	449	449
query55	74	73	73	73
query56	294	272	282	272
query57	1184	1059	1093	1059
query58	254	243	247	243
query59	3544	3216	3105	3105
query60	310	294	280	280
query61	97	102	94	94
query62	829	652	655	652
query63	322	298	296	296
query64	10539	2168	1702	1702
query65	3182	3087	3117	3087
query66	1306	336	337	336
query67	15591	14971	15077	14971
query68	4570	552	544	544
query69	461	333	311	311
query70	1163	1147	1104	1104
query71	398	274	275	274
query72	7166	5458	5500	5458
query73	754	328	328	328
query74	5989	5482	5473	5473
query75	3356	2737	2685	2685
query76	2859	1018	931	931
query77	415	300	309	300
query78	9460	8795	8897	8795
query79	2620	520	511	511
query80	1880	466	471	466
query81	584	222	214	214
query82	760	139	135	135
query83	286	169	168	168
query84	267	91	87	87
query85	1800	310	305	305
query86	456	312	319	312
query87	3257	3103	3138	3103
query88	4437	2490	2454	2454
query89	473	405	388	388
query90	1819	197	197	197
query91	136	102	116	102
query92	76	54	55	54
query93	1843	512	509	509
query94	1132	220	293	220
query95	407	323	319	319
query96	586	277	285	277
query97	3186	2993	3027	2993
query98	213	208	200	200
query99	1480	1252	1271	1252
Total cold run time: 286154 ms
Total hot run time: 173545 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.32 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 73cde74617dcfb810e57e94bff82261bd58291a3, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.03
query3	0.22	0.06	0.05
query4	1.66	0.09	0.09
query5	0.51	0.49	0.49
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.06	0.04	0.04
query9	0.56	0.48	0.50
query10	0.54	0.55	0.53
query11	0.15	0.11	0.11
query12	0.15	0.12	0.13
query13	0.59	0.59	0.59
query14	0.76	0.77	0.79
query15	0.85	0.81	0.80
query16	0.36	0.36	0.36
query17	0.99	1.00	0.93
query18	0.22	0.22	0.22
query19	1.75	1.70	1.68
query20	0.01	0.02	0.01
query21	15.40	0.75	0.66
query22	4.27	8.12	1.65
query23	18.62	1.45	1.31
query24	2.11	0.24	0.22
query25	0.16	0.09	0.09
query26	0.30	0.21	0.21
query27	0.45	0.24	0.23
query28	13.29	1.01	0.99
query29	12.62	3.35	3.33
query30	0.26	0.06	0.05
query31	2.86	0.38	0.38
query32	3.32	0.47	0.47
query33	2.96	2.92	2.91
query34	17.16	4.33	4.40
query35	4.42	4.37	4.40
query36	0.65	0.46	0.48
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.12	0.12
query41	0.10	0.05	0.05
query42	0.05	0.06	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.26 s
Total hot run time: 30.32 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 11, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants